[CLOUDSTACK-7153] addNicToVirtualMachine not BaseAsyncCreate but creates an entity

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.4.0
• Fix Version/s: 4.5.0
• Component/s: Management Server
• Security Level: Public (Anyone can view this level - this is the default.)
• Assignee: Damodar Reddy T
• Reporter: Damodar Reddy T
• Created: 22/Jul/14 09:12
• Updated: 28/Aug/14 11:27
• Resolved: 23/Jul/14 04:15

Description

addNicToVirtualMachine not BaseAsyncCreate but creates an entity.
We need them to be BaseAsyncCreate so that Eventbus while publishing the completed events can put in the entity id. Right now there is a generic logic where after create function when the id is created its pushed into the context so that Eventbus can use it to publish the created UUID. If its not baseAsyncCreate you will have to go into each api and put the id in the context.
Currently following is the generic code had put in ApiServer.java. We will have to do specifically into your api. Do this only if there is a hard reason not to make it baseasyncCreate
Class entityClass = EventTypes.getEntityClassForEvent(createCmd.getEventType());
if (entityClass != null)
ctx.putContextParameter(entityClass.getName(), objectId);