[CLOUDSTACK-7071] Upgrade to 4.2 fails in case a VMware setup has multiple zones managing the same VMware datacenter

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 4.2.0
• Fix Version/s: 4.5.0
• Component/s: Upgrade, VMware
• Security Level: Public (Anyone can view this level - this is the default.)
• Assignee: Likitha Shetty
• Reporter: Likitha Shetty
• Created: 07/Jul/14 11:18
• Updated: 07/Jul/14 11:33
• Resolved: 07/Jul/14 11:33

Description

In a pre-upgrade setup if clusters that belong to one single VMware Datacenter are spread across 3 different CloudStack zones, upgrade to 4.2 will fail.

As part of the new mapping model for CloudStack zone and Vmware datacenter https://issues.apache.org/jira/browse/CLOUDSTACK-1963, during CS upgrade to 4.2 we populate each of the VMware datacenter into either cloud.vmware_datacenter or cloud.legacy_zones table. But our upgrade script doesn't handle a VMware Datacenter that is managed by two different CloudStack zones and hence the it will fail with the following error -

2014-06-19 03:19:27,565 ERROR [c.c.u.d.Upgrade410to420] (main:null) Unable to discover legacy zones.Duplicate entry 'xxx' for key 'guid'
2014-06-19 03:19:27,568 ERROR [c.c.u.DatabaseUpgradeChecker] (main:null) Unable to upgrade the database
com.cloud.utils.exception.CloudRuntimeException: Unable to discover legacy zones.Duplicate entry 'xxx' for key 'guid'
at com.cloud.upgrade.dao.Upgrade410to420.persistLegacyZones(Upgrade410to420.java:979)
at com.cloud.upgrade.dao.Upgrade410to420.performDataMigration(Upgrade410to420.java:80)
at com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(DatabaseUpgradeChecker.java:292)
at com.cloud.upgrade.DatabaseUpgradeChecker.check(DatabaseUpgradeChecker.java:414)