[CLOUDSTACK-6918] CancelStorageMaintenance: Not all vms get restarted as a part of canceling maintenance mode

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 4.4.0
• Fix Version/s: 4.5.0
• Component/s: Storage Controller
• Security Level: Public (Anyone can view this level - this is the default.)
• Assignee: Disheng Su
• Reporter: Alena Prokharchyk
• Created: 16/Jun/14 19:55
• Updated: 18/Jul/14 22:40
• Resolved: 18/Jul/14 22:40

Description

Steps to reproduce:

1) Have one storage pool in a zone.
2) Start regular user vm and the VR
3) Enable storage maintenance. All vms get stopped automatically, and records for them are added to storage_pool_work table with stopped_for_maintenance flag set to 1.
4) Cancel storage maintenance. All the vms that were stopped as a part of maintenance, should be restarted now. But it doesn't happen as StoragePoolAutomationImpl.java, cancelMaintain method when loop through pendingWorks, the result is returned right after the first pendingWork is completed successfully.

for (StoragePoolWorkVO work : pendingWork) {