[CLOUDSTACK-5853] cannot deploy vm with differing service storage tag and data disk storage tag

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 4.2.0, 4.3.0, 4.4.0
• Fix Version/s: 4.4.0, 4.5.0
• Component/s: Management Server
• Security Level: Public (Anyone can view this level - this is the default.)
• Assignee: Prachi Damle
• Reporter: Marcus Sorensen
• Created: 10/Jan/14 17:47
• Updated: 18/Nov/14 22:26
• Resolved: 18/Nov/14 22:26

Description

Create two storage pools, one with storage tag X, one with storage tag Y.
Create a service offering with storage tag X.
Create a disk offering with storage tag Y.
Attempt to deploy a virtual machine with a datadisk, using given offerings, it fails.

Deployment planner keeps a global object 'avoid'. It loops through each volume to be created, asking storage allocators for matching pools, passing this avoid object.

First disk matches a pool or pools, adds ALL other pools to avoid object, then deployment planner attaches matching pools to a list for that disk.

Second disk matches a pool, adds all other pools to avoid object, then deployment planner says "wait, matching pool is in avoid, can't use it". Oops. In fact, at this point ALL pools are in avoid (unless there are other pools that have both tags).

Need to remove matching pool from the avoid set during each select phase.