[CLOUDSTACK-5810] addIpToNic: the owner of the secondary ip should be derived from vmInstance object, not from the caller account

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 4.3.0
• Fix Version/s: 4.4.0
• Component/s: Management Server
• Security Level: Public (Anyone can view this level - this is the default.)
• Assignee: Jayapal
• Reporter: Alena Prokharchyk
• Created: 07/Jan/14 00:16
• Updated: 26/Nov/14 16:48
• Resolved: 24/Jan/14 08:30

Description

Steps to reproduce:
====================
1) Deploy a vm as a regular user account.
2) Login as admin, add secondary ip to the user's vm's nic.

Bug: the secondary ip account owner is set to Admin account. This is wrong, as in CS we never let link objects belonging to diff accounts, unless its a public resource (template, network). In cases like this one, the owner info should be derived from the vm instance object.

Jayapal, I will fix the API, and you have to fix the DB upgrade part. The fix should be: compare the sec ips accounts with the account of corresponding vms, and update nic_secondary_ips if account info is different. Should be done as a part of 43-44 upgrade.