CloudStack
  1. CloudStack
  2. CLOUDSTACK-5140

A stopped vm cant start after disable threshold has been reached on the storage pool

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.2.0, 4.3.0
    • Fix Version/s: 4.2.1, 4.3.0
    • Component/s: Management Server
    • Security Level: Public (Anyone can view this level - this is the default.)
    • Labels:
      None

      Description

      Incorrect primary storage allocation behaviour:

      If a datastore reaches ‘disable threshold’ a stopped VM that was already on that datastore will refuse to start? Pre 4.2 thresholds were only applicable at the allocation time.

      I still see the code is present in 4.2 and master as well that can cause this issue.
      Following highlighted code is what causes it:
      DeploymentPlanningMgrImpl :: findPotentialDeploymentResources () {
      ….

      if (hostCanAccessSPool(potentialHost, potentialSPool)) {
      hostCanAccessPool = true;
      if (multipleVolume)

      { List<Volume> requestVolumes = null; if (volumeAllocationMap.containsKey(potentialSPool)) requestVolumes = volumeAllocationMap.get(potentialSPool); else requestVolumes = new ArrayList<Volume>(); requestVolumes.add(vol); if (!_storageMgr.storagePoolHasEnoughSpace(requestVolumes, potentialSPool)) continue; volumeAllocationMap.put(potentialSPool, requestVolumes); }

      storage.put(vol, potentialSPool);
      haveEnoughSpace = true;
      break;
      }

      }

      Issue is that this check should NOT be done for a Volume that is already created and exists on the pool.

      Happens with a VM having root and data volumes.

        Activity

        Hide
        Prachi Damle added a comment -

        Author: Prachi Damle (prachi@cloud.com)
        Author date: 9 minutes ago (Mon Nov 11 17:59:49 2013 -0800)
        Commit date: 8 minutes ago (Mon Nov 11 18:00:18 2013 -0800)
        Commit hash: 7ba48e7c65a64497ed236d3985b4a04bd16dc2d2

        CS-18506: stopped vm cant start after disable threshold has been reached

        Changes:

        • Do not do the stoarge capacity check for a VM having READY Volumes that are already present on the storagepool.

        Contained in branches: 4.2
        Contained in no tag

        Show
        Prachi Damle added a comment - Author: Prachi Damle (prachi@cloud.com) Author date: 9 minutes ago (Mon Nov 11 17:59:49 2013 -0800) Commit date: 8 minutes ago (Mon Nov 11 18:00:18 2013 -0800) Commit hash: 7ba48e7c65a64497ed236d3985b4a04bd16dc2d2 CS-18506: stopped vm cant start after disable threshold has been reached Changes: Do not do the stoarge capacity check for a VM having READY Volumes that are already present on the storagepool. Contained in branches: 4.2 Contained in no tag
        Hide
        ASF subversion and git services added a comment -

        Commit 60cca0f65eb57560f05961ef7665f3eff3cfc572 in branch refs/heads/master from Prachi Damle
        [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=60cca0f ]

        CLOUDSTACK-5140: A stopped vm cant start after disable threshold has been reached on the storage pool

        Changes:

        • Do not do the stoarge capacity check for a VM having READY Volumes that are already present on the storagepool.

        Conflicts:

        server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java

        Show
        ASF subversion and git services added a comment - Commit 60cca0f65eb57560f05961ef7665f3eff3cfc572 in branch refs/heads/master from Prachi Damle [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=60cca0f ] CLOUDSTACK-5140 : A stopped vm cant start after disable threshold has been reached on the storage pool Changes: Do not do the stoarge capacity check for a VM having READY Volumes that are already present on the storagepool. Conflicts: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java
        Hide
        ASF subversion and git services added a comment -

        Commit 5c984eaef8385c5022127fbad43b74f6bc147050 in branch refs/heads/4.3 from Prachi Damle
        [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5c984ea ]

        CLOUDSTACK-5140: A stopped vm cant start after disable threshold has been reached on the storage pool

        Changes:

        • Do not do the stoarge capacity check for a VM having READY Volumes that are already present on the storagepool.

        Conflicts:

        server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java

        Conflicts:

        server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java

        Show
        ASF subversion and git services added a comment - Commit 5c984eaef8385c5022127fbad43b74f6bc147050 in branch refs/heads/4.3 from Prachi Damle [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5c984ea ] CLOUDSTACK-5140 : A stopped vm cant start after disable threshold has been reached on the storage pool Changes: Do not do the stoarge capacity check for a VM having READY Volumes that are already present on the storagepool. Conflicts: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java Conflicts: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java

          People

          • Assignee:
            Prachi Damle
            Reporter:
            Prachi Damle
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development