[CLOUDSTACK-271] updatePhysicalNetwork dies with an NPE when the vlan range is empty

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.1.0
• Fix Version/s: 4.1.0
• Component/s: Network Controller
• Security Level: Public (Anyone can view this level - this is the default.)
• Assignee: Hugo Trippaers
• Reporter: Hugo Trippaers
• Created: 05/Oct/12 21:32
• Updated: 04/Jun/13 18:51
• Resolved: 05/Oct/12 23:29

Description

2012-10-05 23:18:22,754 ERROR [cloud.api.ApiDispatcher] (Job-Executor-17:job-17) Exception while executing UpdatePhysicalNetworkCmd:
java.lang.NullPointerException
at com.cloud.network.NetworkManagerImpl.checkGuestVnetsConflicts(NetworkManagerImpl.java:5429)
at com.cloud.network.NetworkManagerImpl.updatePhysicalNetwork(NetworkManagerImpl.java:5376)
at com.cloud.utils.component.ComponentLocator$InterceptorDispatcher.intercept(ComponentLocator.java:1231)
at com.cloud.api.commands.UpdatePhysicalNetworkCmd.execute(UpdatePhysicalNetworkCmd.java:99)
at com.cloud.api.ApiDispatcher.dispatch(ApiDispatcher.java:138)
at com.cloud.async.AsyncJobManagerImpl$1.run(AsyncJobManagerImpl.java:432)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
at java.util.concurrent.FutureTask.run(FutureTask.java:166)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
at java.lang.Thread.run(Thread.java:679)

The code should not check for overlapping VLANs is vlans are not used as the isolation type.