CloudStack
  1. CloudStack
  2. CLOUDSTACK-1638

Network plugins won't be notified VM migration.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0.0, 4.0.1, 4.0.2, 4.1.0, 4.1.1, 4.2.0
    • Fix Version/s: 4.2.0
    • Component/s: Management Server
    • Security Level: Public (Anyone can view this level - this is the default.)
    • Labels:

      Description

      The location of the virtual machine is provided by DeployDestination, which will be passed in NetworkGuru#reserve and NetworkElement#prepare.

      During the virtual machine migration, it actually changes DeployDestination and it looks like that it will tell that event to network components as it has NetworkManager#prepareNicForMigration. The problem is that althogh the interface has that method, NetworkManagerImpl does not tell the DeployDestination changes to network components.

      So IMHO, we need to add calls of NetworkGuru#reserve and NetworkElement#prepare in NetworkManagerImpl#prepareNicForMigration . And then, we also need to add calls NetworkGuru#release and NetworkElement#release after the migration, otherwise the network resources that plugin reserved will be kept even when the vm leaves off.

        Activity

        Sheng Yang made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Assignee Chiradeep Vittal [ chiradeep ] Hiroaki Kawai [ kawai ]
        Resolution Fixed [ 1 ]
        Sheng Yang made changes -
        Fix Version/s 4.1.0 [ 12323253 ]
        Chip Childers made changes -
        Fix Version/s 4.0.2 [ 12323754 ]
        Joe Brockmeier made changes -
        Assignee Hiroaki Kawai [ kawai ] Chiradeep Vittal [ chiradeep ]
        Prasanna Santhanam made changes -
        Fix Version/s 4.0.2 [ 12323754 ]
        Fix Version/s 4.1.0 [ 12323253 ]
        Fix Version/s 4.2.0 [ 12323906 ]
        Hiroaki Kawai made changes -
        Affects Version/s 4.0.0 [ 12323251 ]
        Affects Version/s 4.0.1 [ 12323505 ]
        Affects Version/s 4.0.2 [ 12323754 ]
        Affects Version/s 4.1.0 [ 12323253 ]
        Affects Version/s 4.1.1 [ 12324122 ]
        Chip Childers made changes -
        Field Original Value New Value
        Assignee Hiroaki Kawai [ kawai ]
        Hiroaki Kawai created issue -

          People

          • Assignee:
            Hiroaki Kawai
            Reporter:
            Hiroaki Kawai
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development