Uploaded image for project: 'CloudStack'
  1. CloudStack
  2. CLOUDSTACK-10362

Inconsistent method names

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • None
    • None
    • Security Level: Public (Anyone can view this level - this is the default.)
    • None

    Description

      Some Boolean-return methods are named "getXXX",
      but other Boolean-return methods are named "isXXX", such as the following two methods.
      They will return boolean values, rename them as "isXXX" should be more clear than "getXXX".

      api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/ListVlanIpRangesCmd.java

           public Boolean getForVirtualNetwork() {
               return forVirtualNetwork;
           }
      

      api/src/main/java/org/apache/cloudstack/api/command/user/address/ListPublicIpAddressesCmd.java

          public Boolean isForVirtualNetwork() {
              return forVirtualNetwork;
          }
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            BruceKuiLIU KuiLIU
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: