[CLOUDSTACK-10334] Inadequate information for handling catch clauses

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 4.12
• Security Level: Public (Anyone can view this level - this is the default.)
• Labels: easyfix
• Assignee: Unassigned
• Reporter: Zhenhao Li
• Created: 21/Mar/18 14:25
• Updated: 28/Mar/18 10:03
• Resolved: 28/Mar/18 10:03

Description

Their are some situations that different exception types are caught, but the handling of those exceptions can not show the differences of those types. Here are the code snippets we found which have this problem:

cloudstack/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java

https://github.com/apache/cloudstack/blob/893a88d225276e45f12f9490e6af2c94a81c2965/server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java

At Line 261 and Line 265. We can see that two exception types are caught, but the logging statements here can not show the exception type at all.

Also they threw new exceptions after the logs, but the throw statements in these two catch clauses are identical, which are not distinguishable.

It may cause confusions to the person who is reading the log, the person can not know what exception happened here and can not distinguish logs generated by these two statements.

 Maybe adding stack trace information to these two logging statements and change the log message to handle specific situations is a simple way to improve it.

Issue Links

• links to: GitHub Pull Request #2510