Uploaded image for project: 'Click'
  1. Click
  2. CLK-778

EmailField Data Validation Is Insufficient

Add voteWatch issue
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • 3.0.0
    • extras
    • None

    Description

      In the Click Extras project, the current EmailField validation does not sufficiently limit user input to the format of an email address. As an example, I loaded the Avoka examples site and was able to successfully submit the following as an email address in the Extra Form Controls page:

      how.can@this@be@a@valid.email.address

      For my own use I have extended EmailField with the following additional validation logic:

      private static final Pattern EMAIL_ADDRESS_REGEX_PATTERN = Pattern.compile("^[a-zA-Z0-9._%+-]@[a-zA-Z0-9.-]
      .[a-zA-Z]

      {2,4}

      $", Pattern.CASE_INSENSITIVE);
      ...

      @Override
      public void validate() {
      super.validate();
      if (EMAIL_ADDRESS_REGEX_PATTERN.matcher(StringUtils.trimToEmpty(this.value)).matches())

      { this.setErrorMessage("email-format-error"); }

      }

      Attachments

        Issue Links

          Activity

            People

              takezoe Naoki Takezoe
              c.lawrence Clint Lawrence

              Dates

                Created:
                Updated:

                Slack

                  Issue deployment