[CLK-713] Race condition in Menu.getHeadElements

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 2.3.0-M1
• Component/s: extras
• Assignee: Bob Schellink
• Reporter: Finn Bock
• Created: 15/Jul/10 21:01
• Updated: 18/Jul/10 13:00
• Resolved: 18/Jul/10 13:00

Description

Multi threads can access a cached Menu while it is being initialized. The Exception can be:

java.lang.ArrayIndexOutOfBoundsException: 2
at java.util.ArrayList.add(ArrayList.java:352)
at org.apache.click.extras.control.Menu.getHeadElements(Menu.java:1077)
at org.apache.click.util.PageImports.processControl(PageImports.java:37

Initializing the menu in MenuFactory by calling menu.getHeadElements() seems to make the race condition go away.