Uploaded image for project: 'Click'
  1. Click
  2. CLK-712

ConcurrentModificationException during rendering of Css/JsImport element.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3.0-M1
    • Component/s: core
    • Labels:
      None

      Description

      In Css/JsImport.render(), the src/href attribute is temporarily removed:

      // Temporarily remove href attribute while other attributes are rendered
      setAttribute("href", null);

      appendAttributes(buffer);

      // Restore href attribute
      setAttribute("href", href);

      This cause incorrect rendering and ConcurrentModificationException when other threads rendering the same element. The sharing between threads is common for the CSS & JS elements added to a cached menu.

      It is quite easy to reproduce: Just let jmeter hit localhost:8080/click-examples/home.htm about 40.000 times. After the test is finished use a browser to show the examples homepage. For me, the CSS and JS import elements related to menu is missing or rendered incorrectly.

        Attachments

          Activity

            People

            • Assignee:
              sabob Bob Schellink
              Reporter:
              bckfnn Finn Bock
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: