Uploaded image for project: 'Click'
  1. Click
  2. CLK-572

Improve Form validation for subclasses to implement business and cross-field validation

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.0 RC1
    • Fix Version/s: 2.1.0
    • Component/s: core
    • Labels:
      None

      Description

      Its currently not possible for Form subclasses to override and implement custom business and cross-field validation logic in the #validate method, because the validate method is invoked before the Field values are processed and bound to request values.

      Proposed solution is to rename the current Form.validate() method to Form.validateFileUpload (because that is what is currently does) and introduce a new empty validate method which subclasses can override. This is consistent with the approach taken by Field which also provide an empty validate method which subclasses can implement.

        Activity

        Hide
        sabob Bob Schellink added a comment -

        fixed in trunk

        Show
        sabob Bob Schellink added a comment - fixed in trunk

          People

          • Assignee:
            sabob Bob Schellink
            Reporter:
            sabob Bob Schellink
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development