Uploaded image for project: 'Click'
  1. Click
  2. CLK-571

Deprecate Page method, getPageImports, in favor of getHeadElements

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.1.0 RC1
    • Fix Version/s: 2.1.0
    • Component/s: core
    • Labels:
      None

      Description

      getHeadElements negates the need to expose PageImports at the Page level. We should deprecate the methods set/getPageImports.

      The only use case not covered by getHeadElements is when minimizing JavaScript/Css imports on a Page. Currently one can invoke PageImports#setInitialized so that the Controls imports won't be included.

      We could instead add a boolean property on Page to provide similar functionality e.g:

      private boolean includeControlHeadElements;

        Activity

        Hide
        sabob Bob Schellink added a comment -

        fixed in trunk

        Show
        sabob Bob Schellink added a comment - fixed in trunk

          People

          • Assignee:
            sabob Bob Schellink
            Reporter:
            sabob Bob Schellink
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development