[CLK-51] Session-Rewrite-Error when using absolute redirects

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: core
• Environment: Click-0.17
• Assignee: Malcolm Edgar
• Reporter: Maik Jablonski
• Created: 29/Dec/05 18:46
• Updated: 15/Jan/06 08:39
• Resolved: 30/Dec/05 13:35

Description

If you use absolute redirects (turned off cookies), Click fails to rewrite the url:

Example (application):

public boolean onOkClicked()

{ setRedirect("/overview.htm"); }

ClickServlet.java (448ff) handles this case and reads:

package net.sf.click;
...
if (page.getRedirect() != null) {
String url = response.encodeRedirectURL(page.getRedirect());

if (url.charAt(0) == '/')

{ url = request.getContextPath() + url; }
...

This fails because the encodeRedirectURL gets an absolute path ("/overview.htm") with page.getRedirect and recognizes this as a different web-application in the container (and therefore does not rewrite the url).

The "correct" code should look something like this:

if (page.getRedirect() != null) {
String url = page.getRedirect();

if (url.charAt(0) == '/') { url = request.getContextPath() + url; }

url = response.encodeRedirectURL(url)
...