[CLK-312] request.setCharacterEncoding is called after request parameters are read

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: core
• Environment: Click 1.4RC3
• Assignee: Bob Schellink
• Reporter: Bob Schellink
• Created: 12/Feb/08 15:37
• Updated: 06/Mar/08 05:47
• Resolved: 17/Feb/08 00:52

Description

Ricardo identified a problem in ClickServlet where request.setCharacterEncoding is called after ClickRequestWrapper is created which can potentially read request parameters in the case of a file upload.

According to the Servlet javadoc ServletRequest#setCharacterEncoding states:

This method must be called prior to reading request parameters or reading input using getReader().

To fix we can move the request.setCharacterEncoding code before we create a new Context.

Kudos to Ricardo for identifying and providing a fix for this issue!