Uploaded image for project: 'Click'
  1. Click
  2. CLK-283

Table should nullify rowList property

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • None
    • core
    • None
    • Click 1.4RC2

    Description

      Hi Malcolm,

      We use a cache layer on top of read-only DAO's. The result of the DAO methods are placed in unmodifiable collections. However since the table calls rowList.clear() an exception is thrown. If we then pass in the modifiable versions, the actual cache objects are cleared.

      I think a better and less error prone way is to dereference rowList instead:

      public void onDestroy() {
      if (getNullifyRowListOnDestroy())

      { setRowList(null); }

      ...

      What do you think?

      Attachments

        Activity

          People

            sabob Bob Schellink
            sabob Bob Schellink
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment