Uploaded image for project: 'Click'
  1. Click
  2. CLK-283

Table should nullify rowList property

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: core
    • Labels:
      None
    • Environment:
      Click 1.4RC2

      Description

      Hi Malcolm,

      We use a cache layer on top of read-only DAO's. The result of the DAO methods are placed in unmodifiable collections. However since the table calls rowList.clear() an exception is thrown. If we then pass in the modifiable versions, the actual cache objects are cleared.

      I think a better and less error prone way is to dereference rowList instead:

      public void onDestroy() {
      if (getNullifyRowListOnDestroy())

      { setRowList(null); }

      ...

      What do you think?

        Activity

        Hide
        sabob Bob Schellink added a comment -

        Fix check in. Will be available in Click 1.4RC3

        Show
        sabob Bob Schellink added a comment - Fix check in. Will be available in Click 1.4RC3
        Hide
        medgar Malcolm Edgar added a comment -

        I had issues with just nullifying the rowList, which is what I tired initially. However I can remember what the exact issue was with our application.

        OK why don't change the implementation your suggestion, with the default behaviour being to nullify rowList. I will assign the issue to you. Could you please remove the clearRowListOnDestroy property.

        Show
        medgar Malcolm Edgar added a comment - I had issues with just nullifying the rowList, which is what I tired initially. However I can remember what the exact issue was with our application. OK why don't change the implementation your suggestion, with the default behaviour being to nullify rowList. I will assign the issue to you. Could you please remove the clearRowListOnDestroy property.

          People

          • Assignee:
            sabob Bob Schellink
            Reporter:
            sabob Bob Schellink
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development