[CLK-220] Form file upload NPE

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Component/s: core
• Environment: Click 1.3
• Assignee: Malcolm Edgar
• Reporter: Malcolm Edgar
• Created: 10/Jun/07 20:04
• Updated: 22/Jun/07 16:32
• Resolved: 10/Jun/07 20:09

Description

The following bug was raised by David Rosenstark:
---------------------------------------------------------------------

We have some code that was working fine in click 1.2
We changed the jar to be 1.3 and are receiveing errors related to
characterEncoding being null. The form we are submitting has a FileField.

The code that is checking and throwing the exception from the Form class is
here

if (fileItem != null) {
if (request.getCharacterEncoding() == null)

{ formName = fileItem.getString(); }

try

{ formName = fileItem.getString(request.getCharacterEncoding()); }

catch (UnsupportedEncodingException ex)

{ throw new RuntimeException(ex); }

}

Notice how you check to see if getCharacterEncoding() is null and then when
it is null you still do: fileItem.getString(request.getCharacterEncoding());

This line then throws the exception.