Uploaded image for project: 'Click'
  1. Click
  2. CLK-118

Table Column's don't escape their output

    Details

    • Type: New Feature
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: core
    • Labels:
      None

      Description

      Columns don't escape by default This is ognl I have to use to make a table column escape it's value:

      table.addColumn(new Column("@org.apache.commons.lang.StringEscapeUtils@escapeHtml(title)","Title"));

      I propose escaping should be the default and that users should use a call like column.setEscaping(false) to turn it off it not required. This might cause some minor backwards compatibility issues but escaping by default is much more desirable than the small inconvenience this might cause. I might see if I can come up with a patch in the next few days.

        Activity

        Hide
        medgar Malcolm Edgar added a comment -

        Hi Glen,

        Fix checked into SVN, will be available in release 1.0.

        Please take a look at this and see if it fixed your issue.

        regards Malcolm Edgar

        Show
        medgar Malcolm Edgar added a comment - Hi Glen, Fix checked into SVN, will be available in release 1.0. Please take a look at this and see if it fixed your issue. regards Malcolm Edgar
        Hide
        gstamp Glen Stampoultzis added a comment -

        That was quick. Thanks. I'll take a look.

        Show
        gstamp Glen Stampoultzis added a comment - That was quick. Thanks. I'll take a look.
        Hide
        gstamp Glen Stampoultzis added a comment -

        I had a look at the changes you just committed. It looks like what I was expecting. When I have time later I'll checkout and build from SVN manually and see how well it works in practice.

        Show
        gstamp Glen Stampoultzis added a comment - I had a look at the changes you just committed. It looks like what I was expecting. When I have time later I'll checkout and build from SVN manually and see how well it works in practice.

          People

          • Assignee:
            medgar Malcolm Edgar
            Reporter:
            gstamp Glen Stampoultzis
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development