[CLIMATE-882] local data source is not Python 3 compatible

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.0
• Fix Version/s: 1.2.0
• Assignee: Alex Goodman
• Reporter: Alex Goodman
• Created: 20/Oct/16 22:23
• Updated: 21/Oct/16 00:34
• Resolved: 21/Oct/16 00:34

Description

Tests are failing for our python 3 builds because of the local module. Specifically, _get_netcdf_variable_name() raises an exception because Python 3 implicitly treats strings as unicode instead of bytes. The culprit is specifically this line:

dims_lower = [dim.encode().lower() for dim in dimensions]

Because encode() converts the strings to bytes in python 3.

Issue Links

• links to: GitHub Pull Request #414