[CLIMATE-484] Remove rebinning metrics

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.3-incubating
• Fix Version/s: 0.4
• Component/s: metrics
• Labels: Newcomer
• Assignee: Michael Joyce
• Reporter: Michael Joyce
• Created: 02/Jul/14 15:54
• Updated: 14/Jul/14 14:47
• Resolved: 14/Jul/14 14:47

Description

We have a few metrics (Spatial/SeasonalStdDevRatio and similar PatternCorrelation ones) that do a temporal rebin. We've discussed this before, but I think it's worth revisiting.

In my opinion, we shouldn't be doing rebins/regrids/manipulations during an evaluation unless it's 100% necessary for the metric to make sense. In other words:

ds1 = ocw.local.load_file(...)
ds2 = ocw.local.load_file(...)

evaluation = Evaluation.evaluation(ds1, [ds2], [metrics.TemporalStdDevRatio()])
evaluation.run()

Should really be:

ds1 = ocw.local.load_file(...)
ds2 = ocw.local.load_file(...)

ds1 = ocw.dataset_processor.temporal_rebin(ds1, ...)
ds2 = ocw.dataset_processor.temporal_rebin(ds2, ...)

evaluation = Evaluation.evaluation(ds1, [ds2], [metrics.StdDevRatio()])
evaluation.run()

That is a more correct usage of the redesigned API in my opinion.

Thoughts? Comments? I'm going to send a PR for this change, but let's discuss please.

Issue Links

• is depended upon by: CLIMATE-485 Ensure all metrics are included in Sphinx build