[CLIMATE-281] Evaluation Class methods need 'self' added to them

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.2-incubating
• Fix Version/s: 0.3-incubating
• Component/s: analysis

Environment

Mac OS X

• Assignee: Cameron Goodale
• Reporter: Cameron Goodale
• Due: 28/Aug/13
• Created: 28/Aug/13 17:06
• Updated: 28/Aug/13 18:22
• Resolved: 28/Aug/13 18:22

Description

While using the Evaluation Class I kept getting this error:
NameError: global name '_should_run_regular_metrics' is not defined

I looked at the method, and it should be prepend with 'self.' when calling it. I also noticed other private methods didn't include self in their function definition.
_run_no_subregion_evaluation() vs. _run_no_subregion_evaluation(self)
_should_run_regular_metrics() vs. _should_run_regular_metrics(self)

This issue will fix these issue by adding more self to the Class definition. I also plan to add some new tests to run a couple evaluations and exercise the run() method a bit.