[CLI-37] HelpFormatter does not wrap lines correctly after the second line

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 1.0
• Fix Version/s: 1.2
• Component/s: Help formatter
• Bugzilla Id: 17682
• Assignee: Unassigned
• Reporter: Peter Kunszt
• Created: 06/Mar/03 01:18
• Updated: 25/May/09 17:26
• Resolved: 25/Jul/08 12:01

Description

The HelpFormatter does not wrap the option lines correctly because the logic in renderWrappedText seems to be doubled up. on one side, padding is inserted of length nextLineTabStop for every line after the first, but then in findWrapPos this nextLineTabStop is ADDED to the width, resulting in lines rendered not of width, but nextLineTabStop + width.

the following patch fixes this:

--- old/HelpFormatter.java  Wed Mar  5 18:02:18 2003
+++ new/HelpFormatter.java Wed Mar  5 17:59:47 2003
@@ -802,7 +802,7 @@
         while (true)
         {
             text = padding + text.substring(pos).trim();
-            pos = findWrapPos(text, width, nextLineTabStop);
+            pos = findWrapPos(text, width, 0);

             if (pos == -1)
             {

however, this reduces the usage of findWrapPos to always using the third argument = 0 which makes most of its logic obsolete. it could be rewritten to be MUCH shorter. but maybe i'm just missing something.

the output is fully satisfactory now.

Issue Links

• duplicates: CLI-151 HelpFormatter wraps incorrectly on every line beyond the first