[CLI-304] Eliminating message Constructors in Exceptions to avoid misuse

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 1.4
• Component/s: CLI-1.x
• Assignee: Unassigned
• Reporter: Jugal Mistry
• Created: 30/Mar/20 12:07
• Updated: 30/Mar/20 12:40

Description

Please Consider marking the constructors from Exceptions that follow the format:

{{public FooException(final String message) { super(message) }}}

 as private or removing them altogether from the Following classes:

AlreadySelectedException

MissingArgumentException

MissingOptionException

UnrecognisedOptionException

As they are only used within respective class and do not initialize the member fields. If a library uses the above constructors, then projects that depend on the library will get null values for members if the exceptions are caught, which should be avoided