Uploaded image for project: 'Commons CLI'
  1. Commons CLI
  2. CLI-276

Adjust access-modifier of checkRequiredOptions() to protected

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.4
    • Fix Version/s: 1.5
    • Component/s: CLI-1.x
    • Labels:
      None

      Description

      ... for parity with GnuParser, PosixParser and Parser impls to allow sub-class a bit more control.

      I have a use-case in which needs to defer the required-options check, which is doable with GnuParser and PosixParser, but the new DefaultParser doesn't allow this due to a private access-modifier on checkRequiredOptions().

      https://github.com/apache/commons-cli/pull/11

        Issue Links

          Activity

          Hide
          garydgregory Gary Gregory added a comment -

          Hi Jason,

          Thank you for the patch.

          In SVN trunk. Please verify and close.

          commit -m "[CLI-276] Adjust access-modifier of checkRequiredOptions() to protected." -N C:/vcs/svn/apache/commons/trunks-proper/cli/src/changes/changes.xml C:/vcs/svn/apache/commons/trunks-proper/cli/src/main/java/org/apache/commons/cli/DefaultParser.java
              Sending        C:/vcs/svn/apache/commons/trunks-proper/cli/src/changes/changes.xml
              Sending        C:/vcs/svn/apache/commons/trunks-proper/cli/src/main/java/org/apache/commons/cli/DefaultParser.java
              Transmitting file data ...
              Unknown action received: commit finalizing
              Committed revision 1796363.
          

          Gary

          Show
          garydgregory Gary Gregory added a comment - Hi Jason, Thank you for the patch. In SVN trunk. Please verify and close. commit -m "[CLI-276] Adjust access-modifier of checkRequiredOptions() to protected." -N C:/vcs/svn/apache/commons/trunks-proper/cli/src/changes/changes.xml C:/vcs/svn/apache/commons/trunks-proper/cli/src/main/java/org/apache/commons/cli/DefaultParser.java Sending C:/vcs/svn/apache/commons/trunks-proper/cli/src/changes/changes.xml Sending C:/vcs/svn/apache/commons/trunks-proper/cli/src/main/java/org/apache/commons/cli/DefaultParser.java Transmitting file data ... Unknown action received: commit finalizing Committed revision 1796363. Gary
          Hide
          jdillon Jason Dillon added a comment -

          Thx! works as expected

          Show
          jdillon Jason Dillon added a comment - Thx! works as expected
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user jdillon closed the pull request at:

          https://github.com/apache/commons-cli/pull/11

          Show
          githubbot ASF GitHub Bot added a comment - Github user jdillon closed the pull request at: https://github.com/apache/commons-cli/pull/11
          Hide
          jdillon Jason Dillon added a comment -

          Any idea when 1.5 might be out with this fix?

          Show
          jdillon Jason Dillon added a comment - Any idea when 1.5 might be out with this fix?

            People

            • Assignee:
              Unassigned
              Reporter:
              jdillon Jason Dillon
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development