[CLI-249] Message for an illegal character in an option should contain more information

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: CLI-1.x
• Assignee: Unassigned
• Reporter: David Goodenough
• Created: 06/Apr/15 13:21
• Updated: 09/Mar/17 12:35

Description

Currently the code in org.apache.commons.cli.OptionValidator generates an IllegalArgumentException which contains the message:-

"illegal option value '" + ch + "'"

This is generated in two places, one for single character options and one for multi character options.

However this does not tell the caller which option it is contains this
character, which makes debugging the error without the source (i.e most users) extremely difficult.

Would it not be possible to change the message to:-

"illegal option '" + opt + "' value '" + ch + "'"

which would then at least identify the offending option.