[CLI-241] OptionValidator Implementation Does Not Agree With JavaDoc

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2
• Fix Version/s: 1.3
• Component/s: Validation
• Assignee: Unassigned
• Reporter: David Mollitor
• Created: 04/Jul/13 15:14
• Updated: 09/May/15 18:43
• Resolved: 23/Nov/13 15:35

Description

OptionValidator#validateOption

It states in its JavaDoc that:

Validates whether opt is a permissible Option shortOpt. The rules that specify if the opt is valid are:

• it is not NULL
• it is a single character that is either ' '(special case), '?', '@' or a letter
• it is a multi characterthat only contains letters.

The first check in the code though is:

// check that opt is not NULL
if (opt == null)

{ return; }

Consider changing to...

// check that opt is not NULL
if (opt == null)

{ throw new IllegalArgumentException("The option cannot be NULL"); }