[CLI-235] OptionBuilder wrong design

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 1.2
• Component/s: Options definition
• Labels: OptionBuilder
• Assignee: Unassigned
• Reporter: Sergey B.
• Created: 16/Mar/13 15:57
• Updated: 16/Mar/13 16:24
• Resolved: 16/Mar/13 16:24

Description

OptionBuilder uses static variables to do its work. That's why it is not thread safe.

More than that, static builder methods doesn't conform to Java good style of accessing static members. Such members belong to the class and must be accessed in static way.

Consider creating new builder-like class like that:

OptionBuilder optionBuilder = OptionBuilder.newInstance();
options.add(optionBuilder.withDescription().hasArg().create());
options.add(optionBuilder.withDescription().hasArg().create());
options.add(optionBuilder.withDescription().hasArg().create());

Issue Links

• duplicates: CLI-224 OptionBuilder only has static methods, yet many return an OptionBuilder instance