[CLI-225] Special properties option (-Dproperty=value) handled improperly

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Not A Problem
• Affects Version/s: 1.2
• Component/s: CLI-1.x
• Assignee: Unassigned
• Reporter: Alexey Tsvetkov
• Created: 10/May/12 09:05
• Updated: 11/Feb/13 19:58
• Resolved: 11/Feb/13 19:58

Description

In CLI 1.2 the special properties option (-Dproperty=value) is handled improperly. In GnuParser.java from line 80 is as follows:

                    if (opt.indexOf('=') != -1 && options.hasOption(opt.substring(0, opt.indexOf('='))))
                    {
                        // the format is --foo=value or -foo=value
                        tokens.add(arg.substring(0, arg.indexOf('='))); // --foo
                        tokens.add(arg.substring(arg.indexOf('=') + 1)); // value
                    }
                    else if (options.hasOption(arg.substring(0, 2)))
                    {
                        // the format is a special properties option (-Dproperty=value)
                        tokens.add(arg.substring(0, 2)); // -D
                        tokens.add(arg.substring(2)); // property=value
                    }

, but should be:

                    if (opt.indexOf('=') != -1)
                	{
                	    if (options.hasOption(opt.substring(0, opt.indexOf('='))))
	                    {
	                        // the format is --foo=value or -foo=value
	                        tokens.add(arg.substring(0, arg.indexOf('='))); // --foo
	                        tokens.add(arg.substring(arg.indexOf('=') + 1)); // value
	                    }
	                    else if (options.hasOption(arg.substring(0, 2)))
	                    {
	                        // the format is a special properties option (-Dproperty=value)
	                        tokens.add(arg.substring(0, 2)); // -D
	                        tokens.add(arg.substring(2)); // property=value
	                    }
                	}