Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0, 1.1
    • Fix Version/s: 1.2
    • Component/s: CLI-1.x
    • Labels:
      None

      Description

      A number of CLI classes are serializable and could be used e.g. with RMI if only they would implement Serializable

      • Option.java
      • OptionGroup.java
      • CommandLine.java
      • Options.java
      1. CLI-140_yes_141.patch
        2 kB
        Bjorn Townsend
      2. CLI-140_no_141.patch
        3 kB
        Bjorn Townsend

        Activity

        Hide
        bayard Henri Yandell added a comment - - edited

        Consider for 1.2, especially if a patch shows up

        Show
        bayard Henri Yandell added a comment - - edited Consider for 1.2, especially if a patch shows up
        Hide
        bjorn Bjorn Townsend added a comment -

        Implemented serializable in the classes mentioned above. Note that Henning's patch to CLI-141 also implements Serializable in the Option class. Since I don't know which of these patches might be applied first, I've created two:

        If you have already applied the patch for CLI-141, apply CLI-140_yes_141.patch.

        If you have not already applied the patch for CLI-141, apply CLI-140_no_141.patch.

        Show
        bjorn Bjorn Townsend added a comment - Implemented serializable in the classes mentioned above. Note that Henning's patch to CLI-141 also implements Serializable in the Option class. Since I don't know which of these patches might be applied first, I've created two: If you have already applied the patch for CLI-141 , apply CLI-140 _yes_141.patch. If you have not already applied the patch for CLI-141 , apply CLI-140 _no_141.patch.
        Hide
        brianegge Brian Egge added a comment -

        I took a look at the CLI-140_no_141.patch, and I don't see any reason why it shouldn't be applied. I ran a clirr check, and the changes are backwards compatible.

        INFO: 4000: org.apache.commons.cli.CommandLine: Added java.io.Serializable to the set of implemented interfaces
        INFO: 4000: org.apache.commons.cli.Option: Added java.io.Serializable to the set of implemented interfaces
        INFO: 4000: org.apache.commons.cli.OptionGroup: Added java.io.Serializable to the set of implemented interfaces
        INFO: 4000: org.apache.commons.cli.Options: Added java.io.Serializable to the set of implemented interfaces

        Show
        brianegge Brian Egge added a comment - I took a look at the CLI-140 _no_141.patch, and I don't see any reason why it shouldn't be applied. I ran a clirr check, and the changes are backwards compatible. INFO: 4000: org.apache.commons.cli.CommandLine: Added java.io.Serializable to the set of implemented interfaces INFO: 4000: org.apache.commons.cli.Option: Added java.io.Serializable to the set of implemented interfaces INFO: 4000: org.apache.commons.cli.OptionGroup: Added java.io.Serializable to the set of implemented interfaces INFO: 4000: org.apache.commons.cli.Options: Added java.io.Serializable to the set of implemented interfaces
        Hide
        bayard Henri Yandell added a comment -

        Applied 'yes' patch: 596142.

        Show
        bayard Henri Yandell added a comment - Applied 'yes' patch: 596142.

          People

          • Assignee:
            Unassigned
            Reporter:
            henning Henning Schmiedehausen
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development