[CHUKWA-654] HICC session hosts bug

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.6.0
• Fix Version/s: 0.6.0
• Component/s: User Interface

Environment

RHEL5 Hadoop 1.0.3 Hbase0.94.0

• Assignee: Saisai Shao
• Reporter: Saisai Shao
• Created: 03/Aug/12 05:31
• Updated: 05/Aug/12 03:47
• Resolved: 05/Aug/12 02:45

Description

when using Host Selector widget to select one host, like "localhost", in workspace.js code save_host() function

for(var i=0;i< obj.options.length;i++) {
if(obj.options[i].selected) {
if(i!=0)

{ cookie = cookie + "," + obj.options[i].value; }

else

{ cookie = obj.options[i].value; }

}
}
var myAjax=new Ajax.Request(
"/hicc/jsp/session.jsp",

{ asynchronous: false, method: 'post', parameters: "hosts="+cookie }

);
this code will rise a ajax request to set hosts in session, but the hosts variable in session will be set like ",localhost", a additional comma will be added even there is only one host selected. I think this bug is introduced by above code.

And this will cause MetricsController.java getSeriesBySessionAttribute() function

String[] rkeys = (session.getAttribute(skey).toString()).split(",");

to split this hosts variable to a zero length string, like string "" and string "localhost", using this string "" to get data in HBase which will retrieve no data.