Uploaded image for project: 'Chukwa'
  1. Chukwa
  2. CHUKWA-415

agent.sh should load adaptors from both checkpoint file and conf/initial_adaptors

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.4.0
    • Component/s: Data Collection
    • Labels:
      None
    • Release Note:
      Read initial_adaptors at Agent start every time, not just once.

      Description

      Currently when agent.sh is run, the agent will load the adaptors found in the config/initial_adaptors file only of the checkpoints file doesn't exist. If the checkpoint file does exist, the initial_adaptors file is silently ignored. This is misleading and seems like a potential cause of confusion.

      Instead both files should both be checked for adaptors, first the checkpoint file, then the initial_adaptors file. This order would ensure that the same adaptor won't lose it's checkpoint info or get loaded twice if the agent is bounced.

      Also, the agents.log file does a good job of reporting which adaptors are registered, but it doesn't show where they were loaded from. This information would be useful to have if possible.

        Activity

        Hide
        asrabkin Ari Rabkin added a comment -

        We couldn't do this in the past, because we didn't have adaptor names, so duplicate adaptors would get started each time the agent rebooted. Thanks to CHUKWA-5, we now can.

        Show
        asrabkin Ari Rabkin added a comment - We couldn't do this in the past, because we didn't have adaptor names, so duplicate adaptors would get started each time the agent rebooted. Thanks to CHUKWA-5 , we now can.
        Hide
        asrabkin Ari Rabkin added a comment -

        I don't want to rush to commit this without some operational experience. If applies and uses the patch (Bill?), let us know how it goes. In addition, I will experiment with it at Berkeley.

        Show
        asrabkin Ari Rabkin added a comment - I don't want to rush to commit this without some operational experience. If applies and uses the patch (Bill?), let us know how it goes. In addition, I will experiment with it at Berkeley.
        Hide
        billgraham Bill Graham added a comment -

        +1 - this patch is working well for my testing.

        Show
        billgraham Bill Graham added a comment - +1 - this patch is working well for my testing.
        Hide
        asrabkin Ari Rabkin added a comment -

        I will commit this, barring objection.

        Show
        asrabkin Ari Rabkin added a comment - I will commit this, barring objection.
        Hide
        asrabkin Ari Rabkin added a comment -

        I just committed this.

        Show
        asrabkin Ari Rabkin added a comment - I just committed this.
        Hide
        hudson Hudson added a comment -
        Show
        hudson Hudson added a comment - Integrated in Chukwa-trunk #213 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/213/ )

          People

          • Assignee:
            asrabkin Ari Rabkin
            Reporter:
            billgraham Bill Graham
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development