Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.3.0
    • Fix Version/s: 0.3.0
    • Component/s: Data Processors
    • Labels:
      None

      Description

      There's a corner case in SinkArchiver where it does the wrong thing – if the destination dir does not exist. This fixes it. Patch also fixes DirTailer unit test.

      1. archiverTweak2.patch
        0.6 kB
        Ari Rabkin
      2. archiveCornerCase.patch
        4 kB
        Ari Rabkin

        Activity

        Hide
        Eric Yang added a comment -

        +1 looks good.

        Show
        Eric Yang added a comment - +1 looks good.
        Hide
        Ari Rabkin added a comment -

        I just committed this.

        Show
        Ari Rabkin added a comment - I just committed this.
        Hide
        Ari Rabkin added a comment -

        Another small tweak: should delete output directory if empty. This comes into play if a previous invocation fails.

        Show
        Ari Rabkin added a comment - Another small tweak: should delete output directory if empty. This comes into play if a previous invocation fails.
        Hide
        Ari Rabkin added a comment -

        It's a two-line fix that shouldn't affect anybody outside Berkeley, so I'm willing to take silence for consent by tomorrow evening.

        Show
        Ari Rabkin added a comment - It's a two-line fix that shouldn't affect anybody outside Berkeley, so I'm willing to take silence for consent by tomorrow evening.
        Hide
        Eric Yang added a comment -

        +1 looks good.

        Show
        Eric Yang added a comment - +1 looks good.
        Hide
        Ari Rabkin added a comment -

        I just committed this.

        Show
        Ari Rabkin added a comment - I just committed this.
        Hide
        Hudson added a comment -
        Show
        Hudson added a comment - Integrated in Chukwa-trunk #112 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/112/ )

          People

          • Assignee:
            Ari Rabkin
            Reporter:
            Ari Rabkin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development