Uploaded image for project: 'Chukwa'
  1. Chukwa
  2. CHUKWA-212

File descriptor leak in MDL

        Details

        • Type: Bug
        • Status: Resolved
        • Priority: Blocker
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: None
        • Component/s: Data Processors
        • Labels:
          None

          Description

          After a while MDL is no longer able to open new files.

          1. Text File
            CHUKWA-212.patch
            3 kB
            Jerome Boulon
          2. Text File
            CHUKWA-212-2.patch
            3 kB
            Jerome Boulon

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jboulon Jerome Boulon added a comment -

            I have a patch ready but I want to watch MDL for one day before submitting my patch

            Show
            jboulon Jerome Boulon added a comment - I have a patch ready but I want to watch MDL for one day before submitting my patch
            Hide
            Permalink
            jboulon Jerome Boulon added a comment - - edited

            Tested on a test cluster for 24h, processing System metrics data from more than 3000 nodes.

            Show
            jboulon Jerome Boulon added a comment - - edited Tested on a test cluster for 24h, processing System metrics data from more than 3000 nodes.
            Hide
            Permalink
            zhangyongjiang Cheng added a comment -

            -1 reader.close() should be put in the final block. Otherwise when exception happens in the try block, reader will not be closed.

            Show
            zhangyongjiang Cheng added a comment - -1 reader.close() should be put in the final block. Otherwise when exception happens in the try block, reader will not be closed.
            Hide
            Permalink
            jboulon Jerome Boulon added a comment -

            Good catch! I'll regenerate a patch with the close inside the final block.

            Show
            jboulon Jerome Boulon added a comment - Good catch! I'll regenerate a patch with the close inside the final block.
            Hide
            Permalink
            jboulon Jerome Boulon added a comment -

            Move close to final block

            Show
            jboulon Jerome Boulon added a comment - Move close to final block
            Hide
            Permalink
            eyang Eric Yang added a comment -

            +1 on the new patch.

            Show
            eyang Eric Yang added a comment - +1 on the new patch.
            Hide
            Permalink
            eyang Eric Yang added a comment -

            I just committed this, thanks Jerome.

            Show
            eyang Eric Yang added a comment - I just committed this, thanks Jerome.
            Hide
            Permalink
            hudson Hudson added a comment -

            Integrated in Chukwa-trunk #24 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/24/)

            Show
            hudson Hudson added a comment - Integrated in Chukwa-trunk #24 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/24/ )
            Hide
            Permalink
            hudson Hudson added a comment -

            Integrated in Chukwa-trunk #45 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/45/)

            Show
            hudson Hudson added a comment - Integrated in Chukwa-trunk #45 (See http://hudson.zones.apache.org/hudson/job/Chukwa-trunk/45/ )

              People

              • Assignee:
                jboulon Jerome Boulon
                Reporter:
                jboulon Jerome Boulon
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development