Commons Chain
  1. Commons Chain
  2. CHAIN-61

Chain 2.0 trunk build is throwing many warnings as a result of generification changes

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: 2.0
    • Component/s: None
    • Labels:
      None

      Description

      When warnings on turned on for build, there are many unchecked conversion errors. These should be systematically investigated and fixed or given a @SuppressWarnings("unchecked") where needed.

      1. chain-61.diff
        22 kB
        Elijah Zupancic

        Activity

        Hide
        Simone Tripodi added a comment -

        Fixed on /trunk, see r1189035

        Show
        Simone Tripodi added a comment - Fixed on /trunk, see r1189035
        Hide
        Simone Tripodi added a comment -

        Thanks for the suggestions Phil, more than appreciated!
        And thanks Elijah for the patch. I just committed the modifications, see r1189035

        Show
        Simone Tripodi added a comment - Thanks for the suggestions Phil, more than appreciated! And thanks Elijah for the patch. I just committed the modifications, see r1189035
        Hide
        Elijah Zupancic added a comment -

        I have attached another patch to the ticket. I just did a svn update and I
        noticed that the version number increased but there was no change in the
        files themselves. I just ran the patch, then created a new patch from those
        changes and I'm still getting the fuzz warning. I assume that it is
        informing us about some condition in that patching process - can we just
        ignore it?

        On Tue, Oct 25, 2011 at 1:54 PM, Simone Tripodi (Commented) (JIRA) <

        Show
        Elijah Zupancic added a comment - I have attached another patch to the ticket. I just did a svn update and I noticed that the version number increased but there was no change in the files themselves. I just ran the patch, then created a new patch from those changes and I'm still getting the fuzz warning. I assume that it is informing us about some condition in that patching process - can we just ignore it? On Tue, Oct 25, 2011 at 1:54 PM, Simone Tripodi (Commented) (JIRA) <
        Hide
        Phil Steitz added a comment -

        Usually this is the result of some change being committed between the time the patch was created and when you are trying to apply it. Succeeded usually means succeeded - i.e., the patch command was successful in figuring out how to adjust for the changes in the file. What I do in these cases is compare what I get doing svn diff locally after applying the patch to the patch itself. It the changes are the same (and of course, I am happy with the patch), I go ahead and commit. I don't know about the content of this patch, but the patch itself looks fine to me.

        Show
        Phil Steitz added a comment - Usually this is the result of some change being committed between the time the patch was created and when you are trying to apply it. Succeeded usually means succeeded - i.e., the patch command was successful in figuring out how to adjust for the changes in the file. What I do in these cases is compare what I get doing svn diff locally after applying the patch to the patch itself. It the changes are the same (and of course, I am happy with the patch), I go ahead and commit. I don't know about the content of this patch, but the patch itself looks fine to me.
        Hide
        Simone Tripodi added a comment -

        Hi Elijah,
        that is exactly the same way we use at commons

        Maybe is my svn configuration?

        $ svn --version
        svn, version 1.6.16 (r1073529)
           compiled Jun 13 2011, 15:54:33
        
        Copyright (C) 2000-2009 CollabNet.
        Subversion is open source software, see http://subversion.apache.org/
        This product includes software developed by CollabNet (http://www.Collab.Net/).
        
        The following repository access (RA) modules are available:
        
        * ra_neon : Module for accessing a repository via WebDAV protocol using Neon.
          - handles 'http' scheme
          - handles 'https' scheme
        * ra_svn : Module for accessing a repository using the svn network protocol.
          - handles 'svn' scheme
        * ra_local : Module for accessing a repository on local disk.
          - handles 'file' scheme
        
        Show
        Simone Tripodi added a comment - Hi Elijah, that is exactly the same way we use at commons Maybe is my svn configuration? $ svn --version svn, version 1.6.16 (r1073529) compiled Jun 13 2011, 15:54:33 Copyright (C) 2000-2009 CollabNet. Subversion is open source software, see http: //subversion.apache.org/ This product includes software developed by CollabNet (http: //www.Collab.Net/). The following repository access (RA) modules are available: * ra_neon : Module for accessing a repository via WebDAV protocol using Neon. - handles 'http' scheme - handles 'https' scheme * ra_svn : Module for accessing a repository using the svn network protocol. - handles 'svn' scheme * ra_local : Module for accessing a repository on local disk. - handles 'file' scheme
        Hide
        Elijah Zupancic added a comment -

        Hi Simo,

        I'm not sure that I understand the errors below. Does a fuzz of one mean
        that there is a single character difference in whitespace? Outside of the
        patch warnings, did the patch succeed?

        I'm doing: svn diff > chain-61.diff

        Does anyone have any advice on making patches?
        http://httpd.apache.org/dev/patches.html just advises me to use unified
        diffs and that's what svn uses by default. Since this is the second time
        that this type of thing has happened, it leaves me wandering if I have some
        sort of configuration issue with svn.

        Thanks,
        -Elijah

        On Tue, Oct 25, 2011 at 1:18 PM, Simone Tripodi (Commented) (JIRA) <

        Show
        Elijah Zupancic added a comment - Hi Simo, I'm not sure that I understand the errors below. Does a fuzz of one mean that there is a single character difference in whitespace? Outside of the patch warnings, did the patch succeed? I'm doing: svn diff > chain-61.diff Does anyone have any advice on making patches? http://httpd.apache.org/dev/patches.html just advises me to use unified diffs and that's what svn uses by default. Since this is the second time that this type of thing has happened, it leaves me wandering if I have some sort of configuration issue with svn. Thanks, -Elijah On Tue, Oct 25, 2011 at 1:18 PM, Simone Tripodi (Commented) (JIRA) <
        Hide
        Simone Tripodi added a comment -

        Hi Elijah,
        thanks for your contribution! Unfortunately I sadly got issues when applying the patch

        commons-chain simonetripodi$ patch -p0 < ~/Downloads/chain-61.diff 
        patching file src/test/java/org/apache/commons/chain/impl/NonDelegatingFilter.java
        Hunk #1 succeeded at 29 with fuzz 1.
        patching file src/test/java/org/apache/commons/chain/impl/DelegatingFilter.java
        Hunk #1 succeeded at 29 with fuzz 1.
        patching file src/main/java/org/apache/commons/chain/impl/ContextBase.java
        Hunk #1 succeeded at 52 with fuzz 1.
        patching file src/main/java/org/apache/commons/chain/impl/CatalogBase.java
        patching file src/main/java/org/apache/commons/chain/config/ConfigParser.java
        patching file src/main/java/org/apache/commons/chain/config/ConfigRegisterRule.java
        patching file src/main/java/org/apache/commons/chain/web/faces/FacesWebContext.java
        patching file src/main/java/org/apache/commons/chain/web/servlet/ServletPathMapper.java
        patching file src/main/java/org/apache/commons/chain/web/servlet/PathInfoMapper.java
        patching file src/main/java/org/apache/commons/chain/web/servlet/ServletParamValuesMap.java
        patching file src/main/java/org/apache/commons/chain/web/servlet/RequestParameterMapper.java
        patching file src/main/java/org/apache/commons/chain/web/ChainListener.java
        patching file src/main/java/org/apache/commons/chain/web/portlet/PortletApplicationScopeMap.java
        patching file src/main/java/org/apache/commons/chain/web/portlet/PortletParamMap.java
        patching file src/main/java/org/apache/commons/chain/web/ChainResources.java
        

        Can you help me please? Many thanks in advance!

        Show
        Simone Tripodi added a comment - Hi Elijah, thanks for your contribution! Unfortunately I sadly got issues when applying the patch commons-chain simonetripodi$ patch -p0 < ~/Downloads/chain-61.diff patching file src/test/java/org/apache/commons/chain/impl/NonDelegatingFilter.java Hunk #1 succeeded at 29 with fuzz 1. patching file src/test/java/org/apache/commons/chain/impl/DelegatingFilter.java Hunk #1 succeeded at 29 with fuzz 1. patching file src/main/java/org/apache/commons/chain/impl/ContextBase.java Hunk #1 succeeded at 52 with fuzz 1. patching file src/main/java/org/apache/commons/chain/impl/CatalogBase.java patching file src/main/java/org/apache/commons/chain/config/ConfigParser.java patching file src/main/java/org/apache/commons/chain/config/ConfigRegisterRule.java patching file src/main/java/org/apache/commons/chain/web/faces/FacesWebContext.java patching file src/main/java/org/apache/commons/chain/web/servlet/ServletPathMapper.java patching file src/main/java/org/apache/commons/chain/web/servlet/PathInfoMapper.java patching file src/main/java/org/apache/commons/chain/web/servlet/ServletParamValuesMap.java patching file src/main/java/org/apache/commons/chain/web/servlet/RequestParameterMapper.java patching file src/main/java/org/apache/commons/chain/web/ChainListener.java patching file src/main/java/org/apache/commons/chain/web/portlet/PortletApplicationScopeMap.java patching file src/main/java/org/apache/commons/chain/web/portlet/PortletParamMap.java patching file src/main/java/org/apache/commons/chain/web/ChainResources.java Can you help me please? Many thanks in advance!
        Hide
        Elijah Zupancic added a comment -

        Updated patch containing comments on suppressed warnings.

        Show
        Elijah Zupancic added a comment - Updated patch containing comments on suppressed warnings.
        Hide
        Simone Tripodi added a comment -

        thanks once again for your work! I'd like to ask you to provide another patch where @SuppressWarnings("unchecked") are accompanied by a comment where it is justified why the warning can be suppressed.
        Many thanks in advance!

        Show
        Simone Tripodi added a comment - thanks once again for your work! I'd like to ask you to provide another patch where @SuppressWarnings("unchecked") are accompanied by a comment where it is justified why the warning can be suppressed. Many thanks in advance!

          People

          • Assignee:
            Simone Tripodi
            Reporter:
            Elijah Zupancic
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2h
              2h
              Remaining:
              Remaining Estimate - 2h
              2h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development