Commons Chain
  1. Commons Chain
  2. CHAIN-41

Can't build latest source code due to usage of old Digester

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1, 1.2, Nightly Builds
    • Fix Version/s: 1.2
    • Component/s: None
    • Labels:
      None

      Description

      Currently, build.xml retrieves Digester 1.6 for using as a build path entry.
      However, Digester 1.6 doesn't appear to have the Digester.parse(URL) method. This causes org.apache.commons.chain.config.ConfigParser to fail building.

      Switched to use Digester 1.8 and builds fine. Testers work as well.

      1. patch-build.txt
        1 kB
        Isaac Shabtay

        Activity

        Isaac Shabtay created issue -
        Isaac Shabtay made changes -
        Field Original Value New Value
        Affects Version/s 1.1 [ 12311930 ]
        Affects Version/s 1.2 [ 12311963 ]
        Affects Version/s Nightly Builds [ 12311694 ]
        Hide
        Isaac Shabtay added a comment -

        Proposed path to change build.xml so it retrieves Digester 1.8 instead of 1.6.

        Show
        Isaac Shabtay added a comment - Proposed path to change build.xml so it retrieves Digester 1.8 instead of 1.6.
        Isaac Shabtay made changes -
        Attachment patch-build.txt [ 12370740 ]
        Hide
        Simon Kitching added a comment -

        Fixed by updating the build.xml file in trunk to depend on digester-1.8, as per pom.xml.
        Also updated the myfaces dependency to match the current pom.xml too.
        The alternative would be to generate a new ant script from the current pom.xml, but that would need more testing..

        The commons project now uses maven 2.x almost exclusively as its build tool, so ant build scripts can easily get out-of-date now.
        Maybe we should just start removing ant/maven 1.x scripts now?

        The 1.1 release appears ok to me.

        Thanks for reporting this, Isaac.

        Show
        Simon Kitching added a comment - Fixed by updating the build.xml file in trunk to depend on digester-1.8, as per pom.xml. Also updated the myfaces dependency to match the current pom.xml too. The alternative would be to generate a new ant script from the current pom.xml, but that would need more testing.. The commons project now uses maven 2.x almost exclusively as its build tool, so ant build scripts can easily get out-of-date now. Maybe we should just start removing ant/maven 1.x scripts now? The 1.1 release appears ok to me. Thanks for reporting this, Isaac.
        Simon Kitching made changes -
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Closed [ 6 ]
        Niall Pemberton made changes -
        Assignee Simon Kitching [ skitching ]
        Fix Version/s 1.2 [ 12311963 ]

          People

          • Assignee:
            Simon Kitching
            Reporter:
            Isaac Shabtay
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development