[CB-9891] Inconsistent URI encoding causing permission errors on android

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.0, 3.0.0
• Component/s: cordova-plugin-camera, cordova-plugin-file
• Labels: Android reproduced

Environment

Android 5+

• Assignee: Jason Ginchereau
• Reporter: Connor Pearson
• Created: 28/Oct/15 15:06
• Updated: 23/Aug/18 07:07
• Resolved: 13/Nov/15 01:42

Description

Using the camera plugin to get a picture from the photo library returns an encoded URI. If you then call resolveLocalFileSystemURI the fileEntry object returned contains the decoded path component of the URI. This path property is used in the toInternalURL function which means it's also decoded. Because Android gave us permission to the encoded URI, but not the decoded URI, attempting to access the decoded URI results in a permission error.

document.getElementById("myButton").addEventListener("click", function(){
            navigator.camera.getPicture(function(uri){
                console.log(uri); //content://com.android.providers.media.documents/document/image%3A27         
		window.resolveLocalFileSystemURI(uri, function(fileEntry){
                    console.log(fileEntry.toInternalURL()); //cdvfile://localhost/content/com.android.providers.media.documents/document/image:27                                                                              
                    fileEntry.file(function(){alert("success");}, function(){alert("fail");});
                },function(error){
                    // resolved by pulling in PR 119
                    alert("Fail resolveFileSystemURI code: " + error.code);
                });
            }, null, {sourceType: 0, allowEdit: false});
        });

I feel like something must be wrong in one of the plugins, but I'm not sure where.

One possible fix is calling uri.getEncodedPath() instead of uri.getPath in LocalFileSystemURL.parse and then removing the call to encodeURI() from FileSystem.js, but I'm not sure if this is the right strategy. Example

Issue Links

• is duplicated by: CB-9110 Android 5 Using Internal Storage - Cordova File Plugin