Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-9815

Engine name="cordova" should check tools version, not platforms

    XMLWordPrintableJSON

    Details

      Description

      If I use the following engine tag inside some of my plugins

      <engine name="cordova" version=">=4.3.0" />
      

      I see that the tools compares version w/ platforms versions when installing plugins, not the tools version.

      This is due to the following implementation. We should update implementation similar to cordova-plugman and threat cordova version as tools version not platforms.

      https://github.com/apache/cordova-lib/blob/d12be7c3e7b532bdea43321db2a3ce76b5f4d39f/cordova-lib/src/plugman/util/default-engines.js#L22

      module.exports = function(project_dir){
          return {
              'cordova':
                  { 'platform':'*', 'scriptSrc': path.join(project_dir,'cordova','version') },
              'cordova-plugman':
                  { 'platform':'*', 'currentVersion': require('../../../package.json').version },
              'cordova-android':
                  { 'platform':'android', 'scriptSrc': path.join(project_dir,'cordova','version') },
      

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              sgrebnov Sergey Grebnov
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: