[CB-9737] (save flag) unit test failures for spec.14

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Component/s: cordova-lib
• Labels: cordova-ios-4.0.x
• Assignee: Shazron Abdullah
• Reporter: Shazron Abdullah
• Created: 02/Oct/15 07:34
• Updated: 23/Aug/18 06:52
• Resolved: 02/Oct/15 07:42

Description

Failures:

  1) (save flag) plugin add --save spec.14 should save variables
   Message:
     Expected null to be '123456789'.
   Stacktrace:
     Error: Expected null to be '123456789'.
    at /Users/shazron/Desktop/cordova-lib/cordova-lib/spec-cordova/save.spec.js:313:90
    at _fulfilled (/Users/shazron/Desktop/cordova-lib/cordova-lib/node_modules/q/q.js:787:54)
    at self.promiseDispatch.done (/Users/shazron/Desktop/cordova-lib/cordova-lib/node_modules/q/q.js:816:30)
    at Promise.promise.promiseDispatch (/Users/shazron/Desktop/cordova-lib/cordova-lib/node_modules/q/q.js:749:13)
    at /Users/shazron/Desktop/cordova-lib/cordova-lib/node_modules/q/q.js:509:49
    at flush (/Users/shazron/Desktop/cordova-lib/cordova-lib/node_modules/q/q.js:108:17)
    at process._tickCallback (node.js:355:11)

  2) (save flag) plugin add --save spec.14 should save variables
   Message:
     Expected null to be 'myApplication'.
   Stacktrace:
     Error: Expected null to be 'myApplication'.
    at /Users/shazron/Desktop/cordova-lib/cordova-lib/spec-cordova/save.spec.js:314:92
    at _fulfilled (/Users/shazron/Desktop/cordova-lib/cordova-lib/node_modules/q/q.js:787:54)
    at self.promiseDispatch.done (/Users/shazron/Desktop/cordova-lib/cordova-lib/node_modules/q/q.js:816:30)
    at Promise.promise.promiseDispatch (/Users/shazron/Desktop/cordova-lib/cordova-lib/node_modules/q/q.js:749:13)
    at /Users/shazron/Desktop/cordova-lib/cordova-lib/node_modules/q/q.js:509:49
    at flush (/Users/shazron/Desktop/cordova-lib/cordova-lib/node_modules/q/q.js:108:17)
    at process._tickCallback (node.js:355:11)

This change in the phonegap-facebook-plugin broke the test:
https://github.com/Wizcorp/phonegap-facebook-plugin/commit/a2f6dbb80a54eff29a0e09836aebf0dd905fd60a

Fix is to change the plugin id to "phonegap-facebook-plugin":
https://github.com/apache/cordova-lib/blob/07271a5c6162c0b2bee55e1ea23f91ebdfbbb34c/cordova-lib/spec-cordova/save.spec.js#L52