[CB-96] [PGWhitelist processWhitelist] IP adresses handling

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 1.3.0
• Component/s: cordova-ios
• Labels: objective-c phonegap regex wildcard

Environment

Xcode 4

• Assignee: Shazron Abdullah
• Reporter: STB Land
• Created: 30/Nov/11 12:40
• Updated: 23/Aug/18 07:47
• Resolved: 02/Dec/11 00:28

Description

Theses tests fail with version 1.2.0 (not tested before) :

PGWhitelistTests.h

@interface PGWhitelistTests : SenTestCase {
}

PGWhitelistTests.m

#import "PGWhitelistTests.h"
#import <PhoneGap/PGWhitelist.h>

@implementation PGWhitelistTests

- (void)setUp
{
    [super setUp];   
}

- (void)tearDown
{
    [super tearDown];
}

- (void) testIpExactMatch
{    
    NSArray* allowedHosts = [NSArray arrayWithObjects: 
                             @"162.168.1.1",
                             @"162.168.2.1",
                             nil];

    PGWhitelist* whitelist = [[PGWhitelist alloc] initWithArray:allowedHosts];

    STAssertFalse([whitelist URLIsAllowed:[NSURL URLWithString:@"http://mydomain.com"]], nil);
    STAssertTrue([whitelist URLIsAllowed:[NSURL URLWithString:@"http://192.168.1.1"]], nil);
    STAssertTrue([whitelist URLIsAllowed:[NSURL URLWithString:@"http://192.168.2.1"]], nil);
    STAssertFalse([whitelist URLIsAllowed:[NSURL URLWithString:@"http://192.168.3.1"]], nil);

    [whitelist release];
}

- (void) testIpWildcardMatch
{    
    NSArray* allowedHosts = [NSArray arrayWithObjects: 
                             @"162.168.1.*",
                             @"162.168.2.*",
                             nil];

    PGWhitelist* whitelist = [[PGWhitelist alloc] initWithArray:allowedHosts];

    STAssertFalse([whitelist URLIsAllowed:[NSURL URLWithString:@"http://mydomain.com"]], nil);
    STAssertTrue([whitelist URLIsAllowed:[NSURL URLWithString:@"http://192.168.1.1"]], nil);
    STAssertTrue([whitelist URLIsAllowed:[NSURL URLWithString:@"http://192.168.1.2"]], nil);
    STAssertTrue([whitelist URLIsAllowed:[NSURL URLWithString:@"http://192.168.2.1"]], nil);
    STAssertTrue([whitelist URLIsAllowed:[NSURL URLWithString:@"http://192.168.2.2"]], nil);
    STAssertFalse([whitelist URLIsAllowed:[NSURL URLWithString:@"http://192.168.3.1"]], nil);

    [whitelist release];
}

@end