Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-9566

Move plugin cordova-wkwebview-engine to cordova-wkwebview-engine-localhost

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: iOS

      Description

      We are reserving the cordova-wkwebview-engine plugin for direct file:// url loading in iOS 9.

        Issue Links

          Activity

          Hide
          shazron Shazron Abdullah added a comment - - edited

          Take note of the the issue links in this issue that depends on this.
          This plugin should still be in cordova-labs, not sure if we should officially release this – since we want iOS 9 wkwebview-engine plugin to be the one we really support.

          Users can still install this plugin by git url.

          Show
          shazron Shazron Abdullah added a comment - - edited Take note of the the issue links in this issue that depends on this. This plugin should still be in cordova-labs, not sure if we should officially release this – since we want iOS 9 wkwebview-engine plugin to be the one we really support. Users can still install this plugin by git url.
          Hide
          shazron Shazron Abdullah added a comment -

          This plugin should be re-factored to be just a composite of these two plugins:
          1. cordova-labs-local-webserver
          2. cordova-plugin-wkwebview-engine (core)

          Show
          shazron Shazron Abdullah added a comment - This plugin should be re-factored to be just a composite of these two plugins: 1. cordova-labs-local-webserver 2. cordova-plugin-wkwebview-engine (core)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e6d0cc0954a325298cd6540454d915862d408810 in cordova-plugins's branch refs/heads/master from Shazron Abdullah
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugins.git;h=e6d0cc0 ]

          CB-9566 Renamed wkwebview-engine folder to wkwebview-engine-localhost

          Show
          jira-bot ASF subversion and git services added a comment - Commit e6d0cc0954a325298cd6540454d915862d408810 in cordova-plugins's branch refs/heads/master from Shazron Abdullah [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugins.git;h=e6d0cc0 ] CB-9566 Renamed wkwebview-engine folder to wkwebview-engine-localhost
          Hide
          shazron Shazron Abdullah added a comment - - edited

          Need ATS exception in plugin.xml, and CB-9569

              <key>NSAppTransportSecurity</key>
              <dict>
                  <key>NSExceptionDomains</key>
                  <dict>
                      <key>localhost</key>
                      <dict>
                          <key>NSExceptionAllowsInsecureHTTPLoads</key>
                          <true/>
                      </dict>  
                  </dict>  
              </dict>
          

          Note that this ATS exception should be removed when CB-9569 has been implemented (use access tags for exceptions)

          Show
          shazron Shazron Abdullah added a comment - - edited Need ATS exception in plugin.xml, and CB-9569 <key>NSAppTransportSecurity</key> <dict> <key>NSExceptionDomains</key> <dict> <key>localhost</key> <dict> <key>NSExceptionAllowsInsecureHTTPLoads</key> < true /> </dict> </dict> </dict> Note that this ATS exception should be removed when CB-9569 has been implemented (use access tags for exceptions)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 41eceb1343937e3a2711261eda92e0d249f1d908 in cordova-plugins's branch refs/heads/master from Shazron Abdullah
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugins.git;h=41eceb1 ]

          CB-9566 - Added temporary ATS directive to allow localhost loading in iOS 9

          Show
          jira-bot ASF subversion and git services added a comment - Commit 41eceb1343937e3a2711261eda92e0d249f1d908 in cordova-plugins's branch refs/heads/master from Shazron Abdullah [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugins.git;h=41eceb1 ] CB-9566 - Added temporary ATS directive to allow localhost loading in iOS 9
          Hide
          shazron Shazron Abdullah added a comment -

          Revert the previous commit – that should go in the cordova-labs-local-webserver plugin instead.

          Show
          shazron Shazron Abdullah added a comment - Revert the previous commit – that should go in the cordova-labs-local-webserver plugin instead.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 2d3370ddc5c06c9d21afbf00c1b91890b7fade59 in cordova-plugins's branch refs/heads/master from Shazron Abdullah
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugins.git;h=2d3370d ]

          CB-9566 - move ATS exception in Info.plist into local-webserver plugin instead of the wkwebview-engine-localhost plugin

          Show
          jira-bot ASF subversion and git services added a comment - Commit 2d3370ddc5c06c9d21afbf00c1b91890b7fade59 in cordova-plugins's branch refs/heads/master from Shazron Abdullah [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugins.git;h=2d3370d ] CB-9566 - move ATS exception in Info.plist into local-webserver plugin instead of the wkwebview-engine-localhost plugin
          Hide
          shazron Shazron Abdullah added a comment -

          Resolving this. Adding a new issue for the CB-9569 change.

          Show
          shazron Shazron Abdullah added a comment - Resolving this. Adding a new issue for the CB-9569 change.

            People

            • Assignee:
              shazron Shazron Abdullah
              Reporter:
              shazron Shazron Abdullah
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development