[CB-9430] lib/check_reqs.js fails if javac returns an extra line

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.1.0
• Component/s: cordova-android
• Labels: patch

Environment

ubuntu 14.04, cordova 5.1.1, cordova android@4.1.0

• Assignee: Vladimir Kotikov
• Reporter: Vadim Shlyakhov
• Created: 29/Jul/15 13:37
• Updated: 31/Jul/15 23:53
• Resolved: 31/Jul/15 13:54

Description

lib/check_reqs.js fails with

[TypeError: Cannot read property '1' of null]

if javac returns an extra line(s) instead of a single line.

For example:

Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=gasp
javac 1.7.0_79

instead of simply

javac 1.7.0_79

The fix is quite simple:

--- check_reqs.js-	2015-07-29 14:21:54.000000000 +0300
+++ check_reqs.js	2015-07-29 16:11:29.000000000 +0300
@@ -155,7 +155,7 @@
             // javac writes version info to stderr instead of stdout
             return tryCommand('javac -version', msg, true);
         }).then(function (output) {
-            return /^javac ((?:\d+\.)+(?:\d+))/i.exec(output)[1];
+            return /javac ((?:\d+\.)+(?:\d+))/i.exec(output)[1];
         });
     });
 };

i. e. remove leading caret at the parsing regular expression, so it is not anchored to a beginning of a string.