Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-9370

Cordova-js tests are failing on node 0.12

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.1.0
    • Fix Version/s: 4.1.0
    • Component/s: cordova-js
    • Labels:
    • Environment:

      Windows/Mac OSX machine,
      Node JS 0.12.7

      Description

      Since https://github.com/apache/cordova-js/pull/118 unit tests for cordova-js started failing on AppVeyor CI with unclear message Fatal error: Cannot set property length of [object Object] which has only a getter.
      It looks like the origin of failures - updated NodeJS version on AppVeyor build machines. Failure also can be reproduced on local machine with Node@0.12.5 installed.

      The reason of failures - is outdated jsdom-nogyp dependency (last updated about 2 years ago). The solution is to replace jsdom-nogyp with original node-jsdom, which works fine with node@12.x. It also would be great to test such cases through CI.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                vladimir.kotikov Vladimir Kotikov
                Reporter:
                vladimir.kotikov Vladimir Kotikov
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: