[CB-9370] Cordova-js tests are failing on node 0.12

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 4.1.0
• Fix Version/s: 4.1.0
• Component/s: cordova-js
• Labels: cordova-js

Environment

Windows/Mac OSX machine,
Node JS 0.12.7

• Assignee: Vladimir Kotikov
• Reporter: Vladimir Kotikov
• Created: 15/Jul/15 12:29
• Updated: 30/Oct/15 22:41
• Resolved: 01/Sep/15 07:26

Description

Since https://github.com/apache/cordova-js/pull/118 unit tests for cordova-js started failing on AppVeyor CI with unclear message Fatal error: Cannot set property length of [object Object] which has only a getter.
It looks like the origin of failures - updated NodeJS version on AppVeyor build machines. Failure also can be reproduced on local machine with Node@0.12.5 installed.

The reason of failures - is outdated jsdom-nogyp dependency (last updated about 2 years ago). The solution is to replace jsdom-nogyp with original node-jsdom, which works fine with node@12.x. It also would be great to test such cases through CI.

Issue Links

• is related to: CB-9291 Cordova NPM package does not install when Node >= 0.12.x
• relates to: CB-5438 Can't build/test cordova-js on Windows