Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-9330

Remove 'plugman publish' functionality from cordova-lib

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Due to CPR write (publish) access shutdown starting from July 15 we need to make some changes to remove CPR publishing related functionality from Cordova.

      Things, that might be removed:
      1. 'plugman publish/unpublish' commands,
      2. 'registry.publish/unpublish' methods and all related stuff in cordova-lib.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user vladimir-kotikov opened a pull request:

          https://github.com/apache/cordova-plugman/pull/84

          CB-9330 Adds notice about removed plugman commands

          See CB-9330(https://issues.apache.org/jira/browse/CB-9330) for more details

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/MSOpenTech/cordova-plugman CB-9330

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-plugman/pull/84.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #84


          commit ffd8def3a915d8da174d218aac9da0d33d047971
          Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
          Date: 2015-07-08T08:30:17Z

          CB-9330 Adds notice about removed plugman commands


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugman/pull/84 CB-9330 Adds notice about removed plugman commands See CB-9330 ( https://issues.apache.org/jira/browse/CB-9330 ) for more details You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-plugman CB-9330 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugman/pull/84.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #84 commit ffd8def3a915d8da174d218aac9da0d33d047971 Author: Vladimir Kotikov <v-vlkoti@microsoft.com> Date: 2015-07-08T08:30:17Z CB-9330 Adds notice about removed plugman commands
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user vladimir-kotikov opened a pull request:

          https://github.com/apache/cordova-lib/pull/254

          CB-9330 Removes 'plugman publish' related functionality

          See CB-9330(https://issues.apache.org/jira/browse/CB-9330) for more details.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/MSOpenTech/cordova-lib CB-9330

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-lib/pull/254.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #254


          commit a1e4655cbebdf2c8c36e419c6716a9891d3541da
          Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
          Date: 2015-07-08T08:36:36Z

          CB-9330 Removes 'plugman publish' related functionality


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/254 CB-9330 Removes 'plugman publish' related functionality See CB-9330 ( https://issues.apache.org/jira/browse/CB-9330 ) for more details. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-lib CB-9330 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-lib/pull/254.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #254 commit a1e4655cbebdf2c8c36e419c6716a9891d3541da Author: Vladimir Kotikov <v-vlkoti@microsoft.com> Date: 2015-07-08T08:36:36Z CB-9330 Removes 'plugman publish' related functionality
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user nikhilkh commented on a diff in the pull request:

          https://github.com/apache/cordova-lib/pull/254#discussion_r34200986

          — Diff: cordova-lib/src/plugman/plugman.js —
          @@ -169,35 +160,6 @@ plugman.commands = {
          }
          });
          },
          -

          • 'publish' : function(cli_opts) {
              • End diff –

          I wonder if these commands should still be exposed but with a meaningful console.error message on either having to use the older version of plugman < current or if we decide to make CPR read-only - stating that as such.

          Show
          githubbot ASF GitHub Bot added a comment - Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/254#discussion_r34200986 — Diff: cordova-lib/src/plugman/plugman.js — @@ -169,35 +160,6 @@ plugman.commands = { } }); }, - 'publish' : function(cli_opts) { End diff – I wonder if these commands should still be exposed but with a meaningful console.error message on either having to use the older version of plugman < current or if we decide to make CPR read-only - stating that as such.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user purplecabbage commented on a diff in the pull request:

          https://github.com/apache/cordova-lib/pull/254#discussion_r34204394

          — Diff: cordova-lib/src/plugman/plugman.js —
          @@ -169,35 +160,6 @@ plugman.commands = {
          }
          });
          },
          -

          • 'publish' : function(cli_opts) {
              • End diff –

          +1 to leaving the function stubs around for a bit and simply have them output that this functionality is not supported anymore.

          Show
          githubbot ASF GitHub Bot added a comment - Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/254#discussion_r34204394 — Diff: cordova-lib/src/plugman/plugman.js — @@ -169,35 +160,6 @@ plugman.commands = { } }); }, - 'publish' : function(cli_opts) { End diff – +1 to leaving the function stubs around for a bit and simply have them output that this functionality is not supported anymore.
          Hide
          jcesarmobile jcesarmobile added a comment -
          Show
          jcesarmobile jcesarmobile added a comment - The doc about Publishing Plugins should be edited too http://docs.phonegap.com/en/edge/guide_hybrid_plugins_index.md.html#Plugin%20Development%20Guide
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user nikhilkh commented on the pull request:

          https://github.com/apache/cordova-lib/pull/254#issuecomment-119840437

          There is also an update to the docs that is needed.

          Show
          githubbot ASF GitHub Bot added a comment - Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/254#issuecomment-119840437 There is also an update to the docs that is needed.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user vladimir-kotikov opened a pull request:

          https://github.com/apache/cordova-docs/pull/296

          CB-9330 Update documentation about plugins publishing

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/MSOpenTech/cordova-docs CB-9330

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/cordova-docs/pull/296.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #296


          commit f1534330655b3718ddb8a7e6ac9841b69ba07509
          Author: Vladimir Kotikov <v-vlkoti@microsoft.com>
          Date: 2015-07-09T07:19:11Z

          CB-9330 Update documentation about plugins publishing


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-docs/pull/296 CB-9330 Update documentation about plugins publishing You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs CB-9330 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-docs/pull/296.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #296 commit f1534330655b3718ddb8a7e6ac9841b69ba07509 Author: Vladimir Kotikov <v-vlkoti@microsoft.com> Date: 2015-07-09T07:19:11Z CB-9330 Update documentation about plugins publishing
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vladimir-kotikov commented on the pull request:

          https://github.com/apache/cordova-lib/pull/254#issuecomment-119857857

          @nikhilkh done. See https://github.com/apache/cordova-docs/pull/296

          Show
          githubbot ASF GitHub Bot added a comment - Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/254#issuecomment-119857857 @nikhilkh done. See https://github.com/apache/cordova-docs/pull/296
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 64c2c0013c1ba8996458164ce4eb7a133a0ae344 in cordova-lib's branch refs/heads/master from Vladimir Kotikov
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=64c2c00 ]

          CB-9330 Removes 'plugman publish' related functionality

          Show
          jira-bot ASF subversion and git services added a comment - Commit 64c2c0013c1ba8996458164ce4eb7a133a0ae344 in cordova-lib's branch refs/heads/master from Vladimir Kotikov [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=64c2c00 ] CB-9330 Removes 'plugman publish' related functionality
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1a695603b53774d7a28d8b4e204c102c5b95e129 in cordova-lib's branch refs/heads/master from Steve Gill
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=1a69560 ]

          CB-9330 updated wording for warning messages for removal of publish/unpublish commands

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1a695603b53774d7a28d8b4e204c102c5b95e129 in cordova-lib's branch refs/heads/master from Steve Gill [ https://git-wip-us.apache.org/repos/asf?p=cordova-lib.git;h=1a69560 ] CB-9330 updated wording for warning messages for removal of publish/unpublish commands
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-lib/pull/254

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/254
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5875757a1da19504cf4855430cb260cd4598c3b0 in cordova-docs's branch refs/heads/master from Vladimir Kotikov
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=5875757 ]

          CB-9330 Update documentation about plugins publishing. This closes #296

          Show
          jira-bot ASF subversion and git services added a comment - Commit 5875757a1da19504cf4855430cb260cd4598c3b0 in cordova-docs's branch refs/heads/master from Vladimir Kotikov [ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=5875757 ] CB-9330 Update documentation about plugins publishing. This closes #296
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 6c1f91b748e5dd2da78b0d9620808bf4c5e63eda in cordova-docs's branch refs/heads/master from Steve Gill
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=6c1f91b ]

          CB-9330 updated wording about publishing plugins to npm

          Show
          jira-bot ASF subversion and git services added a comment - Commit 6c1f91b748e5dd2da78b0d9620808bf4c5e63eda in cordova-docs's branch refs/heads/master from Steve Gill [ https://git-wip-us.apache.org/repos/asf?p=cordova-docs.git;h=6c1f91b ] CB-9330 updated wording about publishing plugins to npm
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-docs/pull/296

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/296
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user vladimir-kotikov commented on the pull request:

          https://github.com/apache/cordova-plugman/pull/84#issuecomment-122040896

          @stevengill, could you please take a look on this?

          Show
          githubbot ASF GitHub Bot added a comment - Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugman/pull/84#issuecomment-122040896 @stevengill, could you please take a look on this?
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit cbb673b3eaeec47e1c247ffccc0b865696e9833c in cordova-plugman's branch refs/heads/master from Vladimir Kotikov
          [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=cbb673b ]

          CB-9330 Adds notice about removed plugman commands. This closes #84

          Show
          jira-bot ASF subversion and git services added a comment - Commit cbb673b3eaeec47e1c247ffccc0b865696e9833c in cordova-plugman's branch refs/heads/master from Vladimir Kotikov [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugman.git;h=cbb673b ] CB-9330 Adds notice about removed plugman commands. This closes #84
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/cordova-plugman/pull/84

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugman/pull/84

            People

            • Assignee:
              vladimir.kotikov Vladimir Kotikov
              Reporter:
              vladimir.kotikov Vladimir Kotikov
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development