Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-9274

InAppBrowser compile error for Amazon FireOS

    XMLWordPrintableJSON

    Details

    • Flags:
      Patch

      Description

      Attempting to compile the InAppBrowser plugin for Amazon FireOS fails due to the following programming errors:

          [javac] Compiling 8 source files to /path/to/amazon-fireos/ant-build/classes
          [javac] /path/to/amazon-fireos/src/org/apache/cordova/inappbrowser/InAppBrowserDialog.java:51: cannot find symbol
          [javac] symbol  : method hardwareBack()
          [javac] location: class org.apache.cordova.inappbrowser.InAppBrowser
          [javac]             if (this.inAppBrowser.hardwareBack() && this.inAppBrowser.canGoBack()) {
          [javac]                                  ^
          [javac] /path/to/amazon-fireos/src/org/apache/cordova/inappbrowser/InAppBrowserDialog.java:51: cannot find symbol
          [javac] symbol  : method canGoBack()
          [javac] location: class org.apache.cordova.inappbrowser.InAppBrowser
          [javac]             if (this.inAppBrowser.hardwareBack() && this.inAppBrowser.canGoBack()) {
          [javac]                                                                      ^
          [javac] /path/to/amazon-fireos/src/org/apache/cordova/inappbrowser/InAppBrowserDialog.java:52: goBack() has private access in org.apache.cordova.inappbrowser.InAppBrowser
          [javac]                 this.inAppBrowser.goBack();
          [javac]                                  ^
          [javac] Note: /path/to/amazon-fireos/src/org/apache/cordova/inappbrowser/InAppBrowser.java uses or overrides a deprecated API.
          [javac] Note: Recompile with -Xlint:deprecation for details.
          [javac] 3 errors
      

      As best I can determine, this problem has existed since plugin version 0.5.2 and was introduced on August 14 in commit 69ca780772b406ab02ec1bd1a8e4dca70052e926. Previous commits had diverged the implementation of InAppBrowser.java in Amazon FireOS such that it was no longer compatible with the InAppBrowser.java for Android.

      I am preparing a pull request to patch this issue to restore the ability to use the plugin on this platform.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                jcesarmobile jcesarmobile
                Reporter:
                idpaterson Ian Paterson
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: