Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-9071

Update test framework plugin to use Jasmine 2.4.1

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • None
    • None

    Description

      The test framework plugin is currently using Jasmine 2.2.0. I would like to update this version to the latest Jasmine release (currently 2.4.1). It fixes some issues with beforeAll and focused tests among other things.

      Attachments

        Issue Links

          Activity

            githubbot ASF GitHub Bot added a comment -

            GitHub user marcuspridham opened a pull request:

            https://github.com/apache/cordova-plugin-test-framework/pull/13

            CB-9071 Update test framework plugin to use Jasmine 2.3.4

            Updating Jasmine version from 2.2.0 to 2.3.4.

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/marcuspridham/cordova-plugin-test-framework CB-9071

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/cordova-plugin-test-framework/pull/13.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #13


            commit 910619b065b81fc63d508e591dae4865f16c0237
            Author: Marcus Pridham <marcus.pridham@sap.com>
            Date: 2015-05-15T15:41:03Z

            CB-9071 Update test framework plugin to use Jasmine 2.3.4


            githubbot ASF GitHub Bot added a comment - GitHub user marcuspridham opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/13 CB-9071 Update test framework plugin to use Jasmine 2.3.4 Updating Jasmine version from 2.2.0 to 2.3.4. You can merge this pull request into a Git repository by running: $ git pull https://github.com/marcuspridham/cordova-plugin-test-framework CB-9071 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-test-framework/pull/13.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13 commit 910619b065b81fc63d508e591dae4865f16c0237 Author: Marcus Pridham <marcus.pridham@sap.com> Date: 2015-05-15T15:41:03Z CB-9071 Update test framework plugin to use Jasmine 2.3.4
            githubbot ASF GitHub Bot added a comment -

            Github user nikhilkh commented on the pull request:

            https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-116774679

            @dblotsky Can you take a look at this change?

            githubbot ASF GitHub Bot added a comment - Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-116774679 @dblotsky Can you take a look at this change?
            githubbot ASF GitHub Bot added a comment -

            Github user dblotsky commented on the pull request:

            https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-116850705

            On it.

            githubbot ASF GitHub Bot added a comment - Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-116850705 On it.
            githubbot ASF GitHub Bot added a comment -

            Github user dblotsky commented on the pull request:

            https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-116949803

            I've tested on iOS and it seems to work fine. @marcuspridham, did you make any custom changes, or is it just an update of the files that belong to Jasmine?

            githubbot ASF GitHub Bot added a comment - Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-116949803 I've tested on iOS and it seems to work fine. @marcuspridham, did you make any custom changes, or is it just an update of the files that belong to Jasmine?
            githubbot ASF GitHub Bot added a comment -

            Github user marcuspridham commented on the pull request:

            https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117172177

            Just updating the Jasmine files. No custom changes.

            githubbot ASF GitHub Bot added a comment - Github user marcuspridham commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117172177 Just updating the Jasmine files. No custom changes.
            githubbot ASF GitHub Bot added a comment -

            Github user dblotsky commented on the pull request:

            https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117282507

            Ok, LGTM. Merging.

            githubbot ASF GitHub Bot added a comment - Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117282507 Ok, LGTM. Merging.
            githubbot ASF GitHub Bot added a comment -

            Github user dblotsky commented on the pull request:

            https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117333658

            Due to some bugs with iOS, I'm unable to test this after the rebase on my machine. @marcuspridham have you verified that the code works?

            githubbot ASF GitHub Bot added a comment - Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117333658 Due to some bugs with iOS, I'm unable to test this after the rebase on my machine. @marcuspridham have you verified that the code works?
            githubbot ASF GitHub Bot added a comment -

            Github user nikhilkh commented on the pull request:

            https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117366652

            Also, Marcus have you filed the Apache iCLA? If not please sign, scan and send one to secretary@apache.org: http://www.apache.org/licenses/icla.txt

            githubbot ASF GitHub Bot added a comment - Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117366652 Also, Marcus have you filed the Apache iCLA? If not please sign, scan and send one to secretary@apache.org: http://www.apache.org/licenses/icla.txt
            githubbot ASF GitHub Bot added a comment -

            Github user marcuspridham commented on the pull request:

            https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117386712

            Code does work. I have been running my plugin tests with this change.

            For the Cordova mobile spec, I don't have an iOS device on me right now. An iOS 8.3 simulator gives the same result with and without my change (459 spec, 11 failures, 3 pending) this is against Cordova iOS 3.8.0. Failures seem to be with contacts and location which I don't think work with a simulator.

            I have signed the Apache iCLA and committed changes to Cordova before.

            githubbot ASF GitHub Bot added a comment - Github user marcuspridham commented on the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/13#issuecomment-117386712 Code does work. I have been running my plugin tests with this change. For the Cordova mobile spec, I don't have an iOS device on me right now. An iOS 8.3 simulator gives the same result with and without my change (459 spec, 11 failures, 3 pending) this is against Cordova iOS 3.8.0. Failures seem to be with contacts and location which I don't think work with a simulator. I have signed the Apache iCLA and committed changes to Cordova before.

            Commit 4a04f9624c6fbcf09d9726a32a155138388be7c3 in cordova-plugin-test-framework's branch refs/heads/master from mpridham
            [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-test-framework.git;h=4a04f96 ]

            CB-9071 Update test framework plugin to use Jasmine 2.4.1

            This closes #13

            jira-bot ASF subversion and git services added a comment - Commit 4a04f9624c6fbcf09d9726a32a155138388be7c3 in cordova-plugin-test-framework's branch refs/heads/master from mpridham [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-test-framework.git;h=4a04f96 ] CB-9071 Update test framework plugin to use Jasmine 2.4.1 This closes #13
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/cordova-plugin-test-framework/pull/13

            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/13

            Commit 4a04f9624c6fbcf09d9726a32a155138388be7c3 in cordova-plugin-test-framework's branch refs/heads/1.1.x from mpridham
            [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-test-framework.git;h=4a04f96 ]

            CB-9071 Update test framework plugin to use Jasmine 2.4.1

            This closes #13

            jira-bot ASF subversion and git services added a comment - Commit 4a04f9624c6fbcf09d9726a32a155138388be7c3 in cordova-plugin-test-framework's branch refs/heads/1.1.x from mpridham [ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-test-framework.git;h=4a04f96 ] CB-9071 Update test framework plugin to use Jasmine 2.4.1 This closes #13

            PR was merged

            Sujan12 Jan Piotrowski (janpio) added a comment - PR was merged

            People

              Unassigned Unassigned
              mpridham Marcus Pridham
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: