[CB-8577] 'cordova plugin add <plugin> --save' should save variables into config.xml

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Component/s: cordova-lib
• Assignee: Gorkem Ercan
• Reporter: Omar Mefire
• Created: 28/Feb/15 03:07
• Updated: 23/Aug/18 06:50
• Resolved: 02/Mar/15 02:08

Description

When adding a plugin with the --save/autosave option on, the variables (if any is passed) should be saved into config.xml so that the plugin can be auto-restored successfully later during 'prepare' or 'build' operation.

For example:

• cordova create hello com.omefire.hello Hello
• cd hello
• cordova plugin add com.phonegap.plugins.facebookconnect --variable APP_ID="my-app-id" --variable APP_NAME="my-app-name" --save => results in facebook plugin added to config.xml
• cordova prepare android => results in an error message :

" Installing "com.phonegap.plugins.facebookconnect" for android
Failed to install 'com.phonegap.plugins.facebookconnect':Error: Variable(s) missing: APP_ID, APP_NAME "

This issue is due to the fact that 'cordova plugin add <plugin> --save' save variables in config.xml using the <param> tag instead of the <variable> tag.

N.B: on 'cordova prepare <platform>', the plugins are restored from config.xml if they are not yet installed.