Uploaded image for project: 'Apache Cordova'
  1. Apache Cordova
  2. CB-8801 Browserify Master Issue
  3. CB-8441

Delete platform specific src from cordovajs, update browserify and grunt build flow

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: cordova-js
    • Labels:
      None

      Description

      Delete platform specific src from cordovajs since it has been moved to platforms (CB-8417)

      Update browserify builds to look in platform cordova-js-src folder when building cordova-js

      Update grunt cordova-js builds to look in platform folders for platform specific js

      Doc at https://docs.google.com/document/d/14rZxM0Dj4z7Q9UwcnV6tIkLrUSaM17INnmVshuY_oMU/edit?usp=sharing

        Activity

        Hide
        githubbot ASF GitHub Bot added a comment -

        GitHub user stevengill opened a pull request:

        https://github.com/apache/cordova-js/pull/112

        CB-8441 add platforms as devdeps and cordova-js-src to build cordova.js

        • Use legacy-exec/platform when cordova-js-src is not available
        • updated grunt workflow to not require platformVersion flag anymore to build. Instead grab platform version info from platform dependencies.
        • fix bug with browserify workflow where multiple platforms caused incorrect symbolList + asyc issues when adding modules
        • both `grunt compile:browserify` and `grunt compile` are supported.

        You can merge this pull request into a Git repository by running:

        $ git pull https://github.com/stevengill/cordova-js CB-8441

        Alternatively you can review and apply these changes as the patch at:

        https://github.com/apache/cordova-js/pull/112.patch

        To close this pull request, make a commit to your master/trunk branch
        with (at least) the following in the commit message:

        This closes #112


        commit 6c7765e53bed09b88713956861dc9cd085baad2b
        Author: Steve Gill <stevengill97@gmail.com>
        Date: 2015-05-06T18:21:07Z

        CB-8441 added platforms as dev dependencies

        commit 65344c1b127d58151b12105bad0f5e993aad8738
        Author: Steve Gill <stevengill97@gmail.com>
        Date: 2015-05-12T00:10:38Z

        if no --platformVersion, set it to N/A instead of failing

        commit 2c7cf57f9655965a627ee54447ba79c53c6bafac
        Author: Steve Gill <stevengill97@gmail.com>
        Date: 2015-05-12T01:23:08Z

        CB-8441 grunt compile now uses platform dependencies cordova-js-src for platform specific exec files

        commit 156e26053f471095d0bf8298793f8b575e6ba597
        Author: Steve Gill <stevengill97@gmail.com>
        Date: 2015-05-16T00:12:55Z

        CB-8441 updated workflow to use cordova-js-src when available

        commit cb234634f072f049ade498968c5aa9888dd7611c
        Author: Steve Gill <stevengill97@gmail.com>
        Date: 2015-05-18T07:59:43Z

        CB-8441 platformVersion flag not required anymore. Grab version from dependecy platform versions


        Show
        githubbot ASF GitHub Bot added a comment - GitHub user stevengill opened a pull request: https://github.com/apache/cordova-js/pull/112 CB-8441 add platforms as devdeps and cordova-js-src to build cordova.js Use legacy-exec/platform when cordova-js-src is not available updated grunt workflow to not require platformVersion flag anymore to build. Instead grab platform version info from platform dependencies. fix bug with browserify workflow where multiple platforms caused incorrect symbolList + asyc issues when adding modules both `grunt compile:browserify` and `grunt compile` are supported. You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-js CB-8441 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-js/pull/112.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #112 commit 6c7765e53bed09b88713956861dc9cd085baad2b Author: Steve Gill <stevengill97@gmail.com> Date: 2015-05-06T18:21:07Z CB-8441 added platforms as dev dependencies commit 65344c1b127d58151b12105bad0f5e993aad8738 Author: Steve Gill <stevengill97@gmail.com> Date: 2015-05-12T00:10:38Z if no --platformVersion, set it to N/A instead of failing commit 2c7cf57f9655965a627ee54447ba79c53c6bafac Author: Steve Gill <stevengill97@gmail.com> Date: 2015-05-12T01:23:08Z CB-8441 grunt compile now uses platform dependencies cordova-js-src for platform specific exec files commit 156e26053f471095d0bf8298793f8b575e6ba597 Author: Steve Gill <stevengill97@gmail.com> Date: 2015-05-16T00:12:55Z CB-8441 updated workflow to use cordova-js-src when available commit cb234634f072f049ade498968c5aa9888dd7611c Author: Steve Gill <stevengill97@gmail.com> Date: 2015-05-18T07:59:43Z CB-8441 platformVersion flag not required anymore. Grab version from dependecy platform versions
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 994d6bba75771f2df54f50e7459102d34c8d55b3 in cordova-js's branch refs/heads/master from Steve Gill
        [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=994d6bb ]

        CB-8441 grunt compile now uses platform dependencies cordova-js-src for platform specific exec files

        Show
        jira-bot ASF subversion and git services added a comment - Commit 994d6bba75771f2df54f50e7459102d34c8d55b3 in cordova-js's branch refs/heads/master from Steve Gill [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=994d6bb ] CB-8441 grunt compile now uses platform dependencies cordova-js-src for platform specific exec files
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 100e4359a1b77b421d024323cbaaa68d74dd70cd in cordova-js's branch refs/heads/master from Steve Gill
        [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=100e435 ]

        CB-8441 updated workflow to use cordova-js-src when available

        Show
        jira-bot ASF subversion and git services added a comment - Commit 100e4359a1b77b421d024323cbaaa68d74dd70cd in cordova-js's branch refs/heads/master from Steve Gill [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=100e435 ] CB-8441 updated workflow to use cordova-js-src when available
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 358ca61b5187e20746f5019e215254cfd02345c2 in cordova-js's branch refs/heads/master from Steve Gill
        [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=358ca61 ]

        CB-8441 platformVersion flag not required anymore. Grab version from dependecy platform versions

        Show
        jira-bot ASF subversion and git services added a comment - Commit 358ca61b5187e20746f5019e215254cfd02345c2 in cordova-js's branch refs/heads/master from Steve Gill [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=358ca61 ] CB-8441 platformVersion flag not required anymore. Grab version from dependecy platform versions
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 4a250651c3a05d4ca3be67076223d2dd36429063 in cordova-js's branch refs/heads/master from Steve Gill
        [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=4a25065 ]

        CB-8441 added missing requires and updated npm run scripts

        Show
        jira-bot ASF subversion and git services added a comment - Commit 4a250651c3a05d4ca3be67076223d2dd36429063 in cordova-js's branch refs/heads/master from Steve Gill [ https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;h=4a25065 ] CB-8441 added missing requires and updated npm run scripts
        Hide
        githubbot ASF GitHub Bot added a comment -

        Github user asfgit closed the pull request at:

        https://github.com/apache/cordova-js/pull/112

        Show
        githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/112

          People

          • Assignee:
            stevegill Steve Gill
            Reporter:
            stevegill Steve Gill
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development