[CB-8392] Valid Java package names are marked as invalid when trying to add android platform

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Component/s: cordova-android

Environment

cordova-android 3.6.4

• Assignee: Unassigned
• Reporter: Steve Lam
• Created: 31/Jan/15 23:22
• Updated: 23/Aug/18 06:58
• Resolved: 05/Mar/16 01:40

Description

cordova-android 3.6.4 is reporting "com._123abc.MyApp" as invalid Java package while allowing "com.123abc.MyApp" which is an actual invalid Java package name (http://docs.oracle.com/javase/tutorial/java/package/namingpkgs.html).

In bin/lib/create.js, line 150:

if (!/^[a-zA-Z]+(\.[a-zA-Z0-9][a-zA-Z0-9_]*)+$/.test(package_name)) {
    return Q.reject('Package name must look like: com.company.Name');
}

Should be changed to:

if (!/^[a-zA-Z]+(\.[a-zA-Z_][a-zA-Z0-9_]*)+$/.test(package_name) ) {

Thus allowing for valid Java package names such as:

com._123abc.MyApp

Issue Links

• Blocked: CB-8735 bin/create regex is too strict and has issues with numbers